test: migrate tests to use node:test module for better test structure for report worker#56038
Closed
mertcanaltin wants to merge 3 commits intonodejs:mainfrom
Closed
test: migrate tests to use node:test module for better test structure for report worker#56038mertcanaltin wants to merge 3 commits intonodejs:mainfrom
mertcanaltin wants to merge 3 commits intonodejs:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56038 +/- ##
==========================================
+ Coverage 87.95% 87.99% +0.04%
==========================================
Files 656 656
Lines 188372 189103 +731
Branches 35979 36003 +24
==========================================
+ Hits 165687 166409 +722
- Misses 15851 15858 +7
- Partials 6834 6836 +2 |
pmarchini
reviewed
Dec 4, 2024
test/report/test-report-worker.js
Outdated
Comment on lines
11
to
12
| test('Worker threads report basic information', async (t) => { | ||
| await t.test('should include basic information about Worker threads', async () => { |
Member
There was a problem hiding this comment.
nit: Could we also use describe/it to avoid using await t.test?
Not entirely sure about this: could we set concurrency: true, or is sequentiality needed?
Member
Author
There was a problem hiding this comment.
I followed what you said, thank you, the test is more readable
Member
Author
There was a problem hiding this comment.
I hope I understood correctly, when I used --test-concurrency I saw that the tests were successfully synchronized
pmarchini
approved these changes
Dec 4, 2024
Member
Author
jasnell
approved these changes
Dec 28, 2024
lpinca
requested changes
Dec 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored report-worker tests to use the node:test module for better structure and consistency.
this is part of a long pull request: #56024