deps: Added methods to http parser#5601
Closed
RWOverdijk wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
|
👍 |
Contributor
|
I think these changes should be submitted upstream in nodejs/http-parser first. Also, you'll probably want to include tests for the new methods. |
Author
|
@mscdex I'll do that. I can take a look at the tests, but probably more importantly, I suppose these methods have to be implemented. The thing is, I don't really know where they're being implemented. Could you tell me where that is? I'll figure it out on my own, eventually. But some help could speed things up :) |
Member
|
Yeah, we won't be able to accept these changes here. They need to be opened against nodejs/http-parser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
Description of change
As described in RFC2518, RFC4709, RFC5397, RFC5689 and RFC3744 there are a couple of request methods available that haven't been implemented yet.
I did find other issues discussing this, but until then I created a PR. I'm confident I made a mistake, as this is my first contribution to node, so give me hell :)