Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
MattiasBuelens
requested changes
Oct 9, 2024
avivkeller
reviewed
Oct 9, 2024
avivkeller
removed
node-api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55341 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 630 630
Lines 184681 184681
Branches 36147 36140 -7
=======================================
+ Hits 166682 166692 +10
- Misses 11024 11027 +3
+ Partials 6975 6962 -13 |
This was referenced Oct 10, 2024
NathanBaulch
force-pushed
the
typos-test
branch
from
b7b3e45 to
7654f17
Compare
NathanBaulch
force-pushed
the
typos-test
branch
from
7654f17 to
22fb682
Compare
NathanBaulch
force-pushed
the
typos-test
branch
from
22fb682 to
1cd0491
Compare
NathanBaulch
force-pushed
the
typos-test
branch
from
1cd0491 to
cd20493
Compare
aymen94
approved these changes
Jan 14, 2025
bnb
approved these changes
Jan 14, 2025
NathanBaulch
force-pushed
the
typos-test
branch
from
cd20493 to
b58be45
Compare
Ethan-Arrowood
approved these changes
Feb 27, 2025
bnb
reviewed
Feb 27, 2025
bnb
reviewed
Feb 27, 2025
test/fixtures/wpt/streams/transferable/transfer-with-messageport.window.js
Outdated
Show resolved
Hide resolved
bnb
requested changes
Feb 27, 2025
Contributor
bnb
left a comment
bnb
left a comment
There was a problem hiding this comment.
see comments! Otherwise this LGTM
NathanBaulch
force-pushed
the
typos-test
branch
from
b58be45 to
6b461fd
Compare
Member
|
@bnb ptal |
github-actions
bot
removed
the
request-ci
Collaborator
UlisesGascon
approved these changes
Feb 28, 2025
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #55063 covering all the non-comment fixes.
FWIW, the top typos are: