test: fix tests when Amaro is unavailable by richardlau · Pull Request #55320 · nodejs/node

richardlau · 2024-10-08T14:14:29Z

Fix two tests that fail when node is configured --without-amaro.

nodejs-github-bot · 2024-10-08T14:14:34Z

Review requested:

@nodejs/test_runner

avivkeller · 2024-10-08T15:19:39Z

This isn't right, process.features.typescript will check whether the currently running process supports typescript, not whether the executable does. The correct value to check would be process.config.variables.node_use_amaro

codecov · 2024-10-08T15:25:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (9f9069d) to head (207741a).
Report is 248 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55320      +/-   ##
==========================================
- Coverage   88.39%   88.39%   -0.01%     
==========================================
  Files         652      652              
  Lines      186777   186777              
  Branches    36039    36039              
==========================================
- Hits       165109   165100       -9     
- Misses      14917    14927      +10     
+ Partials     6751     6750       -1

see 30 files with indirect coverage changes

aduh95 · 2024-10-08T15:26:25Z

We might want fix the commit message as well s/when amaro unavailable/when Amaro is unavailable/.

richardlau · 2024-10-08T15:27:02Z

This isn't right, process.features.typescript will check whether the currently running process supports typescript, not whether the executable does. The correct value to check would be process.config.variables.node_use_amaro

I figured this out (which is why I changed the state back to draft). Currently running tests locally (both with and without amaro) before pushing up the correction.

marco-ippolito · 2024-10-08T15:34:35Z

also should actually set process.features.typescript to false if amaro is not loaded

aduh95 · 2024-10-10T16:30:00Z

Can you rebase?

richardlau · 2024-10-10T18:19:39Z

Can you rebase?

👍. Will do so once the linter failure on main is fixed.

Fix two tests that fail when `node` is configured `--without-amaro`.

richardlau · 2024-10-11T01:41:53Z

Can you rebase?

👍. Will do so once the linter failure on main is fixed.

Rebased.

nodejs-github-bot · 2024-10-11T02:07:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63040/

nodejs-github-bot · 2024-10-11T02:59:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63041/

nodejs-github-bot · 2024-10-11T05:27:55Z

Landed in 82dab76

Fix two tests that fail when `node` is configured `--without-amaro`. PR-URL: #55320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fix two tests that fail when `node` is configured `--without-amaro`. PR-URL: nodejs#55320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 8, 2024

aduh95 approved these changes Oct 8, 2024

View reviewed changes

richardlau marked this pull request as draft October 8, 2024 15:03

avivkeller added the strip-types Issues or PRs related to strip-types support label Oct 8, 2024

This comment was marked as off-topic.

Sign in to view

richardlau force-pushed the withoutamaro branch from 7c77386 to c05b8ee Compare October 8, 2024 15:58

richardlau marked this pull request as ready for review October 8, 2024 15:58

richardlau changed the title ~~test: fix tests when amaro unavailable~~ test: fix tests when Amaro is unavailable Oct 8, 2024

aduh95 mentioned this pull request Oct 8, 2024

process: fix process.features.typescript when Amaro is unavailable #55323

Merged

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

This comment was marked as outdated.

Sign in to view

atlowChemi approved these changes Oct 8, 2024

View reviewed changes

avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2024

marco-ippolito approved these changes Oct 9, 2024

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2024

lpinca approved these changes Oct 9, 2024

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2024

This comment was marked as outdated.

Sign in to view

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 10, 2024

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 10, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 10, 2024

This comment was marked as outdated.

Sign in to view

aduh95 removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 10, 2024

test: fix tests when Amaro is unavailable

207741a

Fix two tests that fail when `node` is configured `--without-amaro`.

richardlau force-pushed the withoutamaro branch from c05b8ee to 207741a Compare October 11, 2024 01:39

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2024

marco-ippolito approved these changes Oct 11, 2024

View reviewed changes

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2024

nodejs-github-bot merged commit 82dab76 into nodejs:main Oct 11, 2024

aduh95 mentioned this pull request Oct 11, 2024

V22.10.0 proposal #55343

Merged

richardlau deleted the withoutamaro branch October 11, 2024 16:22

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024

Uh oh!

Conversation

richardlau commented Oct 8, 2024

Uh oh!

nodejs-github-bot commented Oct 8, 2024

Uh oh!

avivkeller commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aduh95 commented Oct 8, 2024

Uh oh!

richardlau commented Oct 8, 2024

Uh oh!

This comment was marked as off-topic.

marco-ippolito commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

aduh95 commented Oct 10, 2024

Uh oh!

richardlau commented Oct 10, 2024

Uh oh!

richardlau commented Oct 11, 2024

Uh oh!

nodejs-github-bot commented Oct 11, 2024

Uh oh!

nodejs-github-bot commented Oct 11, 2024

Uh oh!

nodejs-github-bot commented Oct 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

avivkeller commented Oct 8, 2024 •

edited

Loading

codecov bot commented Oct 8, 2024 •

edited

Loading

marco-ippolito commented Oct 8, 2024 •

edited

Loading