module: wrap swc error in ERR_INVALID_TYPESCRIPT_SYNTAX by marco-ippolito · Pull Request #55316 · nodejs/node

marco-ippolito · 2024-10-08T09:09:00Z

This PR wraps swc errors in a Node error to provide a more consistent error handling.

Before this PR

marcoippolito@marcos-MacBook-Pro node % node --experimental-strip-types -p "enum Foo{}"

node:internal/deps/amaro/dist/index:226
          throw takeObject(r1);
          ^
  x TypeScript enum is not supported in strip-only mode
   ,----
 1 | enum Foo{}
   : ^^^^^^^^^^
   `----

(Use `node --trace-uncaught ...` to show where the exception was thrown)

Node.js v22.8.0

After this PR

marcoippolito@marcos-MacBook-Pro node % ./node --experimental-strip-types -p "enum Foo{}"                      
node:internal/modules/helpers:390
    throw new ERR_INVALID_TYPESCRIPT_SYNTAX(error);
    ^

SyntaxError [ERR_INVALID_TYPESCRIPT_SYNTAX]:   x TypeScript enum is not supported in strip-only mode
   ,----
 1 | enum Foo{}
   : ^^^^^^^^^^
   `----

    at stripTypeScriptTypes (node:internal/modules/helpers:390:11)
    at node:internal/main/eval_string:27:3 {
  code: 'ERR_INVALID_TYPESCRIPT_SYNTAX'
}

nodejs-github-bot · 2024-10-08T09:09:05Z

Review requested:

@nodejs/loaders

ShogunPanda

LGTM!

codecov · 2024-10-08T10:51:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (bbdfeeb) to head (902491b).
Report is 284 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55316      +/-   ##
==========================================
- Coverage   88.41%   87.90%   -0.52%     
==========================================
  Files         652      652              
  Lines      186612   186756     +144     
  Branches    36062    35789     -273     
==========================================
- Hits       165001   164170     -831     
- Misses      14885    15803     +918     
- Partials     6726     6783      +57

Files with missing lines	Coverage Δ
lib/internal/errors.js	`94.29% <100.00%> (-2.69%)`	⬇️
lib/internal/modules/helpers.js	`98.20% <100.00%> (-0.82%)`	⬇️

... and 110 files with indirect coverage changes

JakobJingleheimer

LGTM

nodejs-github-bot · 2024-10-08T11:04:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62989/

lib/internal/modules/helpers.js

doc/api/errors.md

lib/internal/modules/helpers.js

nodejs-github-bot · 2024-10-09T03:17:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62998/

mcollina

lgtm

nodejs-github-bot · 2024-10-09T06:13:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63001/

nodejs-github-bot · 2024-10-10T09:12:42Z

Landed in 31a37e7

PR-URL: #55316 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#55316 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Oct 8, 2024

marco-ippolito added the strip-types Issues or PRs related to strip-types support label Oct 8, 2024

ShogunPanda approved these changes Oct 8, 2024

View reviewed changes

JakobJingleheimer approved these changes Oct 8, 2024

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2024

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2024