doc, installer: win - new logo in installer; optim .jpg#5531
doc, installer: win - new logo in installer; optim .jpg#5531eljefedelrodeodeljefe wants to merge 1 commit intonodejs:masterfrom eljefedelrodeodeljefe:installer/win-new-logo
Conversation
mscdex
added
windows
|
https://nodejs.org/download/test/v6.0.0-test20160303761abde90c/ I don't have a Windows machine or VM handy right now to test so could you screenshot both the x86 and x64 installers and post them here please @eljefedelrodeodeljefe? |
|
On parallels, Win10: x64 x86 |
|
Nice, my only question now is whether we should change the Node green bar at the top to match the new style. @nodejs/website can you please look at the above screenshots and tell us if they are acceptable or should we move the strip of green at the top to a different colour, and if so, what colour? |
|
Tested both installers on Windows 2008 R2, both look fine, as the screenshots above for Windows 10. |
doc, installer: change stripe color to RGB 68 136 62
|
Changed the color to the middle tone. See RGB in commit. Squashed the thing. @rvagg When you decide to land this, I'd actually propose on a separate issue to redesign the installer to something more win10 "tile"-like design. Something that might be nice on my quest for a better win dev UX. Maybe then someone wants to throw in some design ideas. |
|
Could you make sure to run the image though imageoptim / optipng (also for jpeg) or similar tools? (Make sure you don't loose quality though) |
|
ran it through imageoptim. Do you see anything specific? |
|
No I just wanted to make sure, less binary bytes in git. |
|
Ah, alright. FYI It's 7 and 9kb now, with 9-14% optimization. When I did it with |
|
@Fishrock123 Btw, just running |
|
LGTM |
|
lgtm landed @ 44c9751 thanks @eljefedelrodeodeljefe |
also change stripe color to RGB 68 136 62 PR-URL: #5531 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org>
also change stripe color to RGB 68 136 62 PR-URL: #5531 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org>
also change stripe color to RGB 68 136 62 PR-URL: #5531 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org>
also change stripe color to RGB 68 136 62 PR-URL: #5531 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org>
also change stripe color to RGB 68 136 62 PR-URL: #5531 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org>
also change stripe color to RGB 68 136 62 PR-URL: #5531 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org>
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select you VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select your VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) #5401
- (Robert Jefe Lindstaedt) #5531
- New option to select your VS Version in the Windows installer
- (julien.waechter) #4645
- Support Visual C++ Build Tools 2015
- (João Reis) #5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) #1325
PR-URL: #5835
8 participants
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
toolsDescription of change
Latest logo iteration makes image adaptation necessary, #5381.
I couldn't get wix or VS to run properly (new to windows dev), but according to what I see in the installer and read in the wix project, this should suffice.
had to close #5391 and reopen here due to rebase foo and GH not being able to reopen closed force-pushed branches. Sorry.
/cc @rvagg can you give Jenkins a try? Could build locally.