test: add resource to internal module stat test#55157
Closed
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
Closed
test: add resource to internal module stat test#55157RafaelGSS wants to merge 2 commits intonodejs:mainfrom
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55157 +/- ##
==========================================
+ Coverage 88.07% 88.24% +0.17%
==========================================
Files 652 651 -1
Lines 183653 183855 +202
Branches 35856 35825 -31
==========================================
+ Hits 161753 162249 +496
+ Misses 15146 14921 -225
+ Partials 6754 6685 -69 |
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
approved these changes
Sep 30, 2024
github-actions
bot
removed
the
request-ci
Collaborator
anonrig
approved these changes
Sep 30, 2024
RafaelGSS
added
author ready
RafaelGSS
added a commit
that referenced
this pull request
Oct 7, 2024
PR-URL: #55157 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Member
Author
|
Landed in 6c92c13 |
aduh95
pushed a commit
that referenced
this pull request
Oct 9, 2024
PR-URL: #55157 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55157 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito
added
the
dont-land-on-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55157 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing from #51344