test_runner: support typescript files in default glob#55081
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 29, 2024
Merged
test_runner: support typescript files in default glob#55081nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
cjihrig
reviewed
Sep 23, 2024
avivkeller
changed the title
kPatterns
avivkeller
force-pushed
the
patch-647672
branch
2 times, most recently
from
9264b9e to
ea8bdb4
Compare
avivkeller
force-pushed
the
patch-647672
branch
from
ea8bdb4 to
0a4f389
Compare
|
May be worths also to update docs section. Currently is only mentioned there that js files will be processed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55081 +/- ##
=======================================
Coverage 88.24% 88.25%
=======================================
Files 652 651 -1
Lines 183880 183859 -21
Branches 35858 35857 -1
=======================================
- Hits 162271 162261 -10
+ Misses 14900 14891 -9
+ Partials 6709 6707 -2
|
rluvaton
reviewed
Sep 24, 2024
cjihrig
reviewed
Sep 24, 2024
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
The code and docs changes LGTM, but see the previous comment on the test.
avivkeller
force-pushed
the
patch-647672
branch
from
4e5221b to
277c56e
Compare
marco-ippolito
approved these changes
Sep 28, 2024
avivkeller
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
jasnell
approved these changes
Sep 28, 2024
Collaborator
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 27dab9d |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55081 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55081 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55081 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito
added
the
dont-land-on-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55081 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft. I haven't added tests for this change yet.Ready for review
Fixes #55078
Fixes nodejs/help#3902