test_runner: report error on missing sourcemap source#55037
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 23, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
errors
avivkeller
commented
Sep 21, 2024
avivkeller
added
coverage
avivkeller
force-pushed
the
fix-coverage-sourcemap-missing-source
branch
from
3723a8d to
4badc52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55037 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 652 652
Lines 183855 183921 +66
Branches 35856 35862 +6
=======================================
+ Hits 162227 162287 +60
- Misses 14909 14914 +5
- Partials 6719 6720 +1
|
cjihrig
reviewed
Sep 21, 2024
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
The changes LGTM to me but I'd rather not make a bunch of unrelated changes in this PR.
Member
Author
|
IMO they are semi-related, because I moved |
Contributor
Please do. |
atlowChemi
approved these changes
Sep 21, 2024
avivkeller
force-pushed
the
fix-coverage-sourcemap-missing-source
branch
from
4badc52 to
31ed46d
Compare
Co-Authored-By: Jayden Seric <me@jaydenseric.com> Co-Authored-By: Colin Ihrig <cjihrig@gmail.com>
avivkeller
force-pushed
the
fix-coverage-sourcemap-missing-source
branch
from
31ed46d to
462fb41
Compare
Member
Author
|
@atlowChemi I force-pushed to include the co-authors, so you'll need to re-approve before starting a CI. (Sorry!) |
atlowChemi
approved these changes
Sep 21, 2024
github-actions
bot
removed
the
request-ci
Collaborator
3 tasks
avivkeller
added
the
author ready
Member
Author
|
|
Collaborator
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 4f88179 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
Co-Authored-By: Jayden Seric <me@jaydenseric.com> Co-Authored-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #55037 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Co-Authored-By: Jayden Seric <me@jaydenseric.com> Co-Authored-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: nodejs#55037 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
marco-ippolito
added
the
backport-requested-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Co-Authored-By: Jayden Seric <me@jaydenseric.com> Co-Authored-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: nodejs#55037 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54756
ERR_SOURCE_MAP_MISSING_SOURCEis now thrown when a sourcemap contains a reference to a non-existent file.@jaydenseric provided the test fixture, and @cjihrig provided the initial patch.