test: reduce stack size for test-error-serdes by jasnell · Pull Request #54840 · nodejs/node

jasnell · 2024-09-07T21:00:41Z

Hopefully reduces the run time and the likelihood of the test failing with a flaky timeout error.

Refs: #52630

jasnell · 2024-09-07T21:02:13Z

Stress test: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/532/

codecov · 2024-09-07T22:06:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (e1e312d) to head (4001157).
Report is 172 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54840      +/-   ##
==========================================
- Coverage   87.90%   87.89%   -0.01%     
==========================================
  Files         651      651              
  Lines      183343   183343              
  Branches    35710    35712       +2     
==========================================
- Hits       161165   161155      -10     
+ Misses      15466    15461       -5     
- Partials     6712     6727      +15

see 32 files with indirect coverage changes

LiviaMedeiros · 2024-09-08T09:03:29Z

IIRC this made test more flaky on armv7 (32bit), do we still have these in stress CI?

jasnell · 2024-09-08T17:25:45Z

@LiviaMedeiros .... can you expand on that a bit more? Maybe a link to prior attempts/discussion

Stress test covers:

LiviaMedeiros · 2024-09-08T17:52:18Z

can you expand on that a bit more? Maybe a link to prior attempts/discussion

b3d0804 (#52674) was an attempt to do the same. The source of flakiness was confirmed to be code using ErrorWithCyclicCause and the change indeed speeds up unwinding, however limiting stack size haven't solved the issue (basically, when the bug appears and test is not killed by timeout, it stayed in loop for 20+ minutes regardless of stack limit) and for whatever reason made it flake on armv7 even more frequently.
I don't see an option to start stress test CI on any 32bit arch though.

jasnell · 2024-09-08T17:57:02Z

@LiviaMedeiros ... good fun.. ok. Did anyone try moving the test to the sequential suite rather than the parallel suite? Maybe there's just too much going on concurrently

LiviaMedeiros · 2024-09-08T18:05:54Z

The flake was reproducible locally (although not as frequent as in CI) using sequential for i in $(seq 9999); do echo $i; node test.js; done, but it's worth a try.

Hopefully reduces the run time and the likelihood of the test failing with a flaky timeout error.

jasnell · 2024-09-08T18:10:08Z

@LiviaMedeiros ... done! Moved the test over to sequential with the lower stack limit. Let's give this a try and see if it at least reduces how often it flakes.

jasnell · 2024-09-08T18:12:28Z

heh, we kicked off CI at the same time lol.

LiviaMedeiros · 2024-09-08T18:16:13Z

Almost cancelled at the same time as well 😄
Stress CI just in case: https://ci.nodejs.org/job/node-stress-single-test/534/

aduh95

🎉

nodejs-github-bot · 2024-09-11T15:27:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62328/

Hopefully reduces the run time and the likelihood of the test failing with a flaky timeout error. remove test-error-serdes from flaky list move test-error-serdes to sequential PR-URL: #54840 Refs: #52630 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

jasnell · 2024-09-11T22:31:52Z

Landed in 3783499

Hopefully reduces the run time and the likelihood of the test failing with a flaky timeout error. remove test-error-serdes from flaky list move test-error-serdes to sequential PR-URL: #54840 Refs: #52630 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Hopefully reduces the run time and the likelihood of the test failing with a flaky timeout error. remove test-error-serdes from flaky list move test-error-serdes to sequential PR-URL: nodejs#54840 Refs: nodejs#52630 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

jasnell requested review from aduh95, anonrig, joyeecheung and targos September 7, 2024 21:00

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 7, 2024