src: move more stuff over to use Maybe<void> by jasnell · Pull Request #54831 · nodejs/node

jasnell · 2024-09-07T14:54:12Z

Convert more things to use Maybe instead of Maybe

codecov · 2024-09-07T16:26:40Z

Codecov Report

Attention: Patch coverage is 43.39623% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (a1cd3c8) to head (d7f1948).
Report is 397 commits behind head on main.

Files with missing lines	Patch %	Lines
src/api/environment.cc	42.85%	11 Missing and 1 partial ⚠️
src/spawn_sync.cc	36.36%	6 Missing and 1 partial ⚠️
src/node_messaging.cc	40.00%	3 Missing and 3 partials ⚠️
src/cares_wrap.cc	0.00%	2 Missing and 2 partials ⚠️
src/node_env_var.cc	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54831      +/-   ##
==========================================
+ Coverage   87.71%   88.24%   +0.53%     
==========================================
  Files         651      651              
  Lines      183877   183882       +5     
  Branches    35546    35859     +313     
==========================================
+ Hits       161280   162262     +982     
+ Misses      15843    14906     -937     
+ Partials     6754     6714      -40

Files with missing lines	Coverage Δ
src/api/hooks.cc	`83.72% <100.00%> (ø)`
src/base_object.cc	`83.67% <100.00%> (ø)`
src/base_object.h	`88.88% <ø> (ø)`
src/node_internals.h	`83.01% <ø> (ø)`
src/node_messaging.h	`63.15% <ø> (ø)`
src/spawn_sync.h	`100.00% <ø> (ø)`
src/util.h	`90.16% <ø> (ø)`
src/node_env_var.cc	`84.81% <66.66%> (ø)`
src/cares_wrap.cc	`65.16% <0.00%> (ø)`
src/node_messaging.cc	`83.50% <40.00%> (-0.14%)`	⬇️
... and 2 more

... and 86 files with indirect coverage changes

targos · 2024-09-07T17:12:12Z

I guess it must be semver-major as it changes the API

nodejs-github-bot · 2024-09-11T14:43:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62324/

jasnell · 2024-09-11T15:29:10Z

@nodejs/tsc ... this will need another TSC review due to being semver-major

joyeecheung · 2024-09-19T13:11:50Z

Can we just split out the node.h changes to a different PR to reduce backporting conflicts?

jasnell · 2024-09-22T15:19:50Z

Can we just split out the node.h changes to a different PR to reduce backporting conflicts?

Done. PR should no longer be semver-major

jasnell · 2024-09-22T16:14:51Z

hmm... some relevant test failures to investigate...

src/spawn_sync.cc

nodejs-github-bot · 2024-09-24T17:11:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62740/ 💛

PR-URL: #54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

jasnell · 2024-09-26T19:59:32Z

Landed in 812806a

PR-URL: #54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

jasnell requested review from addaleax and targos September 7, 2024 14:54

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 7, 2024

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 7, 2024

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024

This comment was marked as outdated.

Sign in to view

jasnell requested a review from anonrig September 8, 2024 19:07

jasnell force-pushed the use-maybevoid-more branch from 4fc399d to bbfc24b Compare September 11, 2024 14:42

anonrig approved these changes Sep 11, 2024

View reviewed changes

jasnell force-pushed the use-maybevoid-more branch from bbfc24b to b2ca235 Compare September 22, 2024 15:16

This comment was marked as outdated.

Sign in to view

jasnell force-pushed the use-maybevoid-more branch from b2ca235 to f90a790 Compare September 22, 2024 15:18

This comment was marked as outdated.

Sign in to view

jasnell removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 22, 2024

jasnell requested a review from anonrig September 22, 2024 15:20

anonrig approved these changes Sep 22, 2024

View reviewed changes

jasnell marked this pull request as draft September 22, 2024 16:14

targos reviewed Sep 22, 2024

View reviewed changes

src/spawn_sync.cc Show resolved Hide resolved

src: move more stuff over to use Maybe<void>

d7f1948

jasnell force-pushed the use-maybevoid-more branch from f90a790 to d7f1948 Compare September 24, 2024 17:09

jasnell marked this pull request as ready for review September 24, 2024 17:09

targos approved these changes Sep 26, 2024

View reviewed changes

jasnell added a commit that referenced this pull request Sep 26, 2024

src: move more stuff over to use Maybe<void>

812806a

PR-URL: #54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

jasnell closed this Sep 26, 2024

targos pushed a commit that referenced this pull request Oct 4, 2024

src: move more stuff over to use Maybe<void>

49eb68b

PR-URL: #54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

targos pushed a commit that referenced this pull request Oct 4, 2024

src: move more stuff over to use Maybe<void>

a96d5d1

PR-URL: #54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024

src: move more stuff over to use Maybe<void>

d8bba4e

PR-URL: nodejs#54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024

src: move more stuff over to use Maybe<void>

4f5a8e1

PR-URL: nodejs#54831 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

src: move more stuff over to use Maybe<void>#54831

src: move more stuff over to use Maybe<void>#54831
jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell:use-maybevoid-more

jasnell commented Sep 7, 2024

Uh oh!

codecov bot commented Sep 7, 2024 •

edited

Loading

Uh oh!

targos commented Sep 7, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 11, 2024

Uh oh!

jasnell commented Sep 11, 2024

Uh oh!

joyeecheung commented Sep 19, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

jasnell commented Sep 22, 2024 •

edited

Loading

Uh oh!

jasnell commented Sep 22, 2024

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 24, 2024 •

edited by jasnell

Loading

Uh oh!

jasnell commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

jasnell commented Sep 7, 2024

Uh oh!

codecov bot commented Sep 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

targos commented Sep 7, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 11, 2024

Uh oh!

jasnell commented Sep 11, 2024

Uh oh!

joyeecheung commented Sep 19, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

jasnell commented Sep 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Sep 22, 2024

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 24, 2024 • edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Sep 7, 2024 •

edited

Loading

jasnell commented Sep 22, 2024 •

edited

Loading

nodejs-github-bot commented Sep 24, 2024 •

edited by jasnell

Loading