test: remove need to make fs call for zlib test#54814
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 12, 2024
Merged
test: remove need to make fs call for zlib test#54814nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
avivkeller
added
fs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54814 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 651 651
Lines 183364 183364
Branches 35714 35716 +2
=======================================
+ Hits 161171 161176 +5
Misses 15465 15465
+ Partials 6728 6723 -5 |
jasnell
approved these changes
Sep 7, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
anonrig
force-pushed
the
zlib-flush-test
branch
from
d0c3813 to
52bc26f
Compare
jasnell
approved these changes
Sep 10, 2024
jasnell
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/54814 ✔ Done loading data for nodejs/node/pull/54814 ----------------------------------- PR info ------------------------------------ Title test: remove need to make fs call for zlib test (#54814) Author Yagiz Nizipli <yagiz@nizipli.com> (@anonrig) Branch anonrig:zlib-flush-test -> nodejs:main Labels fs, zlib, test, author ready Commits 1 - test: remove need to make fs call for zlib test Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/54814 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54814 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 06 Sep 2024 16:25:11 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54814#pullrequestreview-2292954442 ✘ This PR needs to wait 71 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-10T02:21:02Z: https://ci.nodejs.org/job/node-test-pull-request/62230/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - test: remove need to make fs call for zlib test - Querying data for job/node-test-pull-request/62230/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10797440128 |
github-actions
bot
removed
the
request-ci
Collaborator
avivkeller
removed
the
commit-queue-failed
Collaborator
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/54814 ✔ Done loading data for nodejs/node/pull/54814 ----------------------------------- PR info ------------------------------------ Title test: remove need to make fs call for zlib test (#54814) Author Yagiz Nizipli <yagiz@nizipli.com> (@anonrig) Branch anonrig:zlib-flush-test -> nodejs:main Labels fs, zlib, test, author ready Commits 1 - test: remove need to make fs call for zlib test Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/54814 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54814 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 06 Sep 2024 16:25:11 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54814#pullrequestreview-2292954442 ✘ This PR needs to wait 51 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-11T02:57:39Z: https://ci.nodejs.org/job/node-test-pull-request/62300/ - Querying data for job/node-test-pull-request/62300/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10812410160 |
mcollina
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8eb9353 |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54814 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need for making a filesystem call to a fixture file, and wrap the test suite in test while also avoiding the call to listen for process on exit handler.