zlib: use new.target to check for instantiation

[anonrig]

Referring to @nicolo-ribaudo's comment: #54676 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (4c844a2) to head (e74e917).
Report is 151 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54694      +/-   ##
==========================================
+ Coverage   87.33%   87.60%   +0.27%     
==========================================
  Files         650      650              
  Lines      182832   182843      +11     
  Branches    35067    35384     +317     
==========================================
+ Hits       159670   160180     +510     
+ Misses      16421    15929     -492     
+ Partials     6741     6734       -7     

Files with missing lines	Coverage Δ
lib/zlib.js	98.21% <100.00%> (+0.97%)	⬆️

... and 59 files with indirect coverage changes

[anonrig]

@nodejs/tsc this is a semver-major because the removed test is broken.

[ljharb]

Suggested change

	if (!new.target) {
	if (new.target !== Deflate) {

if you also want to normalize subclasses

[mcollina]

Is this more performant? Would it work with subclasses?

[aduh95]

That seems like something we would want to support, at least using ES6 class syntax

[nicolo-ribaudo]

With the ES6 syntax this test would still pass (except if doing #54694 (comment)).

I guess this change only makes sense if done together with #54676, since this is about detecting when new is used or not.

[mcollina]

I'm -1, we should keep supporting the removed test