test: update test-aborted-util to use node:test#54578
test: update test-aborted-util to use node:test#54578jasnell wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but I worry that things like lazySpawn() here will make it more difficult for folks to contribute (particularly new people). If I'm writing a Node.js unit test, child_process is always available. If I also need to worry about other runtimes, how do I know which Node core modules are safe to use and which would require the lazySpawn() treatment?
I'd imagine that folks would write the test specifically for node.js and those of us who might need to adjust things would have the burden of updating the test or adapting the runtime to it. Alternatively, we could move the |
This comment was marked as outdated.
This comment was marked as outdated.
PR-URL: #54578 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 097dcfc |
PR-URL: #54578 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #54578 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #54578 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
added
the
dont-land-on-v20.x
PR-URL: nodejs#54578 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
5 participants
No description provided.