test: use test runner in test-report-config#54571
Closed
avivkeller wants to merge 1 commit intonodejs:mainfrom
Closed
test: use test runner in test-report-config#54571avivkeller wants to merge 1 commit intonodejs:mainfrom
test-report-config#54571avivkeller wants to merge 1 commit intonodejs:mainfrom
Conversation
Member
avivkeller
commented
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54571 +/- ##
==========================================
- Coverage 87.33% 87.30% -0.03%
==========================================
Files 649 649
Lines 182620 182755 +135
Branches 35042 35046 +4
==========================================
+ Hits 159490 159560 +70
- Misses 16394 16462 +68
+ Partials 6736 6733 -3 |
jasnell
approved these changes
Aug 27, 2024
Member
|
We should find a better way to describe the changes if these refactorings become recurrent, because this is not using the test runner (which whould be |
Contributor
|
Maybe say "node:test" instead of test runner as done in #54585 and similar PRs. |
cjihrig
approved these changes
Aug 28, 2024
Collaborator
Member
Author
|
commit message updated :-) |
Collaborator
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.