build: add --without-amaro build flag#54136
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Aug 2, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Member
|
should the flag be added to the vcbuild.bat too? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54136 +/- ##
=======================================
Coverage 87.06% 87.07%
=======================================
Files 643 643
Lines 181576 181576
Branches 34894 34891 -3
=======================================
+ Hits 158088 158106 +18
+ Misses 16759 16753 -6
+ Partials 6729 6717 -12
|
marco-ippolito
added
the
strip-types
Contributor
Author
Not my area of expertise, and no way for me to test it, but I'd say no based on the fact that |
github-actions
bot
removed
the
request-ci
Collaborator
anonrig
approved these changes
Jul 31, 2024
RafaelGSS
approved these changes
Jul 31, 2024
Collaborator
Collaborator
Collaborator
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1e3a347 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54136 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
targos
added
the
dont-land-on-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55798 Refs: nodejs#54136 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55798 Refs: nodejs#54136 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
./configure --without-amaro, the resultingnodebinary won't contain the Amaro source (which includes the SWC WASM binary). This PR does not remove the--experimental-strip-typesCLI flag, when using this flag an error will be emitted when trying to load amodule-typescriptorcommonjs-typescriptmodule.