typings: fix typo on quic onSessionDatagram#54064
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jul 29, 2024
Merged
typings: fix typo on quic onSessionDatagram#54064nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Member
1ilsang
commented
Jul 27, 2024
1ilsang
commented
- Fix wrong typo
This was referenced Jul 27, 2024
H4ad
approved these changes
Jul 27, 2024
H4ad
reviewed
Jul 27, 2024
Member
H4ad
left a comment
H4ad
left a comment
There was a problem hiding this comment.
Can you change your commit message to be more clear about what are you fixing?
Something like: typings: fix typo on quic onSessionDatagram
1ilsang
force-pushed
the
fix/typings-typo
branch
from
bdb2c6b to
d2cf2df
Compare
Member
Author
anonrig
approved these changes
Jul 27, 2024
anonrig
added
author ready
deokjinkim
changed the title
deokjinkim
approved these changes
Jul 28, 2024
jakecastelli
approved these changes
Jul 28, 2024
lpinca
approved these changes
Jul 28, 2024
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 5210cd8 |
targos
pushed a commit
that referenced
this pull request
Jul 30, 2024
PR-URL: #54064 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54064 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.