build: support lint-js-fix in vcbuild.bat#53695
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Aug 6, 2024
Merged
build: support lint-js-fix in vcbuild.bat#53695nodejs-github-bot merged 1 commit intonodejs:mainfrom
lint-js-fix in vcbuild.bat#53695nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
build
anonrig
approved these changes
Jul 2, 2024
anonrig
added
author ready
H4ad
approved these changes
Jul 2, 2024
StefanStojanovic
approved these changes
Jul 2, 2024
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Jul 4, 2024
VoltrexKeyva
approved these changes
Jul 6, 2024
Member
Author
|
Hey, is this ready for (Assuming no more merge conflicts) |
H4ad
added
commit-queue
Member
|
Not yet, we need to wait the security releases to be able to retry the CI that is failing. |
Collaborator
Collaborator
Member
Author
|
All tests pass :-) |
Collaborator
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in accf2ac |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #53695 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53046 had merge conflicts that would not disappear, this PR is a re-write of that one to prevent further conflicts.
Previously approved by: @jasnell @anonrig @MoLow @H4ad