tools: lock versions of irrelevant DB deps#53546
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 24, 2024
Merged
tools: lock versions of irrelevant DB deps#53546nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
`caniuse-lite` and `electron-to-chromium` are "database dependencies" that we don't care about and are often updated, increasing the size of the repository each time. Lock their versions to the currently installed one so it doesn't happen in the future.
jasnell
approved these changes
Jun 22, 2024
benjamingr
approved these changes
Jun 22, 2024
lpinca
approved these changes
Jun 22, 2024
MoLow
approved these changes
Jun 22, 2024
anonrig
approved these changes
Jun 23, 2024
targos
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e0e0b1a |
targos
added a commit
that referenced
this pull request
Jun 25, 2024
`caniuse-lite` and `electron-to-chromium` are "database dependencies" that we don't care about and are often updated, increasing the size of the repository each time. Lock their versions to the currently installed one so it doesn't happen in the future. PR-URL: #53546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
added a commit
that referenced
this pull request
Jun 25, 2024
`caniuse-lite` and `electron-to-chromium` are "database dependencies" that we don't care about and are often updated, increasing the size of the repository each time. Lock their versions to the currently installed one so it doesn't happen in the future. PR-URL: #53546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caniuse-liteandelectron-to-chromiumare "database dependencies"that we don't care about and are often updated, increasing the size of
the repository each time. Lock their versions to the currently
installed one so it doesn't happen in the future.