Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
anonrig
reviewed
Jun 19, 2024
jasnell
force-pushed
the
beginnings-of-nbytes-library
branch
from
5e837f2 to
81fb3b1
Compare
Member
Author
|
I've converted those into todos. However, given that there is no external repo yet these may be a bit premature. Specifically, there is no version to add to |
anonrig
reviewed
Jun 19, 2024
anonrig
approved these changes
Jun 19, 2024
Member
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
LGTM. node_metadata.cc needs to be updated to remove base64 version, but other than that everything is perfect.
ronag
approved these changes
Jun 19, 2024
Projects that seek to implement Node.js compatible APIs end up needed to reproduce various bits of functionality internally in order to faithfully replicate the Node.js behaviors. This is particularly true for things like byte manipulation, base64 and hex encoding, and other low-level operations. This change proposes moving much of this low-level byte manipulation code out of nodejs/src and into a new `nbytes` library. Initially this new library will exist in the `deps` directory but the intent is to spin out a new separate repository to be its home in the future. Doing so will allow other projects to use the nbytes library with exactly the same implementation as Node.js. This commit moves only the byte swapping and legacy base64 handling code. Additional commits will move additional byte manipulation logic into the library.
jasnell
force-pushed
the
beginnings-of-nbytes-library
branch
from
81fb3b1 to
8201113
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jun 19, 2024
jasnell
force-pushed
the
beginnings-of-nbytes-library
branch
from
8201113 to
d0414df
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
jasnell
force-pushed
the
beginnings-of-nbytes-library
branch
from
d0414df to
8e1b829
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
beginnings-of-nbytes-library
branch
from
8e1b829 to
13c8029
Compare
Collaborator
legendecas
reviewed
Jun 20, 2024
jasnell
commented
Jun 21, 2024
legendecas
approved these changes
Jun 21, 2024
jasnell
added a commit
that referenced
this pull request
Jun 21, 2024
Projects that seek to implement Node.js compatible APIs end up needed to reproduce various bits of functionality internally in order to faithfully replicate the Node.js behaviors. This is particularly true for things like byte manipulation, base64 and hex encoding, and other low-level operations. This change proposes moving much of this low-level byte manipulation code out of nodejs/src and into a new `nbytes` library. Initially this new library will exist in the `deps` directory but the intent is to spin out a new separate repository to be its home in the future. Doing so will allow other projects to use the nbytes library with exactly the same implementation as Node.js. This commit moves only the byte swapping and legacy base64 handling code. Additional commits will move additional byte manipulation logic into the library. PR-URL: #53507 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
Author
|
Landed in d335487 |
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Projects that seek to implement Node.js compatible APIs end up needed to reproduce various bits of functionality internally in order to faithfully replicate the Node.js behaviors. This is particularly true for things like byte manipulation, base64 and hex encoding, and other low-level operations. This change proposes moving much of this low-level byte manipulation code out of nodejs/src and into a new `nbytes` library. Initially this new library will exist in the `deps` directory but the intent is to spin out a new separate repository to be its home in the future. Doing so will allow other projects to use the nbytes library with exactly the same implementation as Node.js. This commit moves only the byte swapping and legacy base64 handling code. Additional commits will move additional byte manipulation logic into the library. PR-URL: nodejs#53507 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 25, 2024
Projects that seek to implement Node.js compatible APIs end up needed to reproduce various bits of functionality internally in order to faithfully replicate the Node.js behaviors. This is particularly true for things like byte manipulation, base64 and hex encoding, and other low-level operations. This change proposes moving much of this low-level byte manipulation code out of nodejs/src and into a new `nbytes` library. Initially this new library will exist in the `deps` directory but the intent is to spin out a new separate repository to be its home in the future. Doing so will allow other projects to use the nbytes library with exactly the same implementation as Node.js. This commit moves only the byte swapping and legacy base64 handling code. Additional commits will move additional byte manipulation logic into the library. PR-URL: #53507 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects that seek to implement Node.js compatible APIs (like workerd) end up needing to reproduce various bits of functionality internally in order to faithfully replicate the Node.js behaviors. This is particularly true for things like byte manipulation, base64 and hex encoding, and other low-level operations. This change proposes moving much of this low-level byte manipulation code out of nodejs/src and into a new
nbyteslibrary. Initially this new library will exist in thedepsdirectory but the intent is to spin out a new separate repository to be its home in the future. Doing so will allow other projects to use the nbytes library with exactly the same implementation as Node.js.This PR moves only the byte swapping, legacy base64 handling, hex encoding/decoding and force ascii code. Additional commits will move additional byte manipulation logic into the library.
The separate library repo will not be created until we've moved everything from src to nbytes that should be moved.
Removing the base64.h and base64-inl.h headers here may be a breaking change for native addons. That'll need to be looked at. If it is, feel free to mark this as a semver-major change.