doc: indicate requirement on VS 17.6 or newer#53301
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 6, 2024
Merged
doc: indicate requirement on VS 17.6 or newer#53301nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
VS 17.6 or newer is a requirement for all Windows platforms rather than ARM-only.
nodejs-github-bot
added
build
lpinca
approved these changes
Jun 3, 2024
StefanStojanovic
approved these changes
Jun 3, 2024
Contributor
StefanStojanovic
left a comment
StefanStojanovic
left a comment
There was a problem hiding this comment.
Line 641 * Visual Studio 17.6.0 or newer in the Optional requirements for compiling for Windows 10 on ARM (ARM64): section can be removed since that is added in the mandatory requirements now.
anonrig
approved these changes
Jun 3, 2024
VoltrexKeyva
approved these changes
Jun 3, 2024
Member
Author
You can have either one of |
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2b7f3d0 |
richardlau
added
dont-land-on-v18.x
dont-land-on-v20.x
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 7, 2024
VS 17.6 or newer is a requirement for all Windows platforms rather than ARM-only. PR-URL: #53301 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
VS 17.6 or newer is a requirement for all Windows platforms rather than ARM-only. PR-URL: nodejs#53301 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
VS 17.6 or newer is a requirement for all Windows platforms rather than ARM-only. PR-URL: nodejs#53301 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS 17.6 or newer is a requirement for all Windows platforms rather than ARM-only.
At the moment this version requirement is only listed under the section "Optional requirements for compiling for Windows 10 on ARM".