Skip to content

[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd""#53144

Closed
marco-ippolito wants to merge 1 commit intonodejs:v20.x-stagingfrom
marco-ippolito:feat/fix-revert-revert
Closed

[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd""#53144
marco-ippolito wants to merge 1 commit intonodejs:v20.x-stagingfrom
marco-ippolito:feat/fix-revert-revert

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented May 25, 2024

This reverts commit 8d20b64.
Fixes: #53143

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams labels May 25, 2024
@marco-ippolito marco-ippolito mentioned this pull request May 25, 2024
Closed
@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 25, 2024 •
edited
Loading

Apparently "Revert 'Revert" is not valid commit message 😆

@marco-ippolito marco-ippolito force-pushed the feat/fix-revert-revert branch 2 times, most recently from 715d3b5 to 0600cf1 Compare May 25, 2024 06:12
@marco-ippolito marco-ippolito changed the title [v20.x backport] Revert "Revert "stream: fix cloned webstreams not being unref'd"" [v20.] Revert "Revert "stream: fix cloned webstreams not being unref'd"" May 25, 2024
@marco-ippolito marco-ippolito changed the title [v20.] Revert "Revert "stream: fix cloned webstreams not being unref'd"" [v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" May 25, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59394/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59397/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59400/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59401/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59415/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59422/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59428/

@marco-ippolito

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59439/

@marco-ippolito marco-ippolito force-pushed the feat/fix-revert-revert branch from 0600cf1 to beedf90 Compare May 27, 2024 11:54
@marco-ippolito marco-ippolito mentioned this pull request May 27, 2024
Merged
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59448/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59457/

mcollina
mcollina approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

marco-ippolito added a commit that referenced this pull request May 27, 2024
@marco-ippolito
Revert "stream: revert fix cloned webstreams not being unref'd"
cffd2cc 
This reverts commit 8d20b64.

PR-URL: #53144
Fixes: #53143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 27, 2024

Landed in cffd2cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-ippolito @nodejs-github-bot @mcollina @RafaelGSS