test_runner: handle file rename and deletion under watch mode#53114
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Jun 2, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
jakecastelli
force-pushed
the
fix-test-runner-rename-delete-error
branch
from
174efbb to
019625e
Compare
atlowChemi
reviewed
May 23, 2024
jakecastelli
force-pushed
the
fix-test-runner-rename-delete-error
branch
from
019625e to
d23cbc4
Compare
jakecastelli
force-pushed
the
fix-test-runner-rename-delete-error
branch
2 times, most recently
from
1f0ae63 to
0d22545
Compare
Member
Author
|
@MoLow I have added tests to cover both |
jakecastelli
force-pushed
the
fix-test-runner-rename-delete-error
branch
from
0d22545 to
b1816bb
Compare
MoLow
reviewed
May 25, 2024
MoLow
approved these changes
May 28, 2024
atlowChemi
approved these changes
May 29, 2024
Member
Author
|
Could someone help me to kick start the CI? 👀 Thanks! |
Collaborator
Member
Author
|
Looks like there are a few failing jobs (most likely flaky tests 👀) I guess they need a rerun? |
Collaborator
rluvaton
approved these changes
Jun 1, 2024
Collaborator
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7125931 |
targos
pushed a commit
that referenced
this pull request
Jun 3, 2024
Fixes: #53113 PR-URL: #53114 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
Fixes: nodejs#53113 PR-URL: nodejs#53114 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Fixes: nodejs#53113 PR-URL: nodejs#53114 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Fixes: #53113 PR-URL: #53114 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Fixes: #53113 PR-URL: #53114 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
Merged
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
When a watched test file is being deleted then the referenced dependency file(s) will be updated incorrect when `unfilterFilesOwnedBy` method is called, which will cause tests not being rerun when its referenced dependency changed. To prevent this case, we can simply `return` when we detect a watched test file being deleted. PR-URL: #53533 Refs: #53114 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
When a watched test file is being deleted then the referenced dependency file(s) will be updated incorrect when `unfilterFilesOwnedBy` method is called, which will cause tests not being rerun when its referenced dependency changed. To prevent this case, we can simply `return` when we detect a watched test file being deleted. PR-URL: #53533 Refs: #53114 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #53113