doc: remove unavailable youtube link in pull requests#52982
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 16, 2024
Merged
Conversation
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet.
avivkeller
added
the
fast-track
avivkeller
approved these changes
May 14, 2024
Contributor
|
Fast-track has been requested by @redyetidev. Please 👍 to approve. |
Member
Speaking only for myself here - every time you take collaborator specific actions like proposing fast-tracking or approving PRs (rather than actually reviewing hard stuff etc) it creates the impression you're having a hard time understanding project boundaries which makes it harder to trust you with further responsibility. |
Member
|
From archive.org thte video is "Code Review on GitHub" by "GitHub Training & Guides" 
@MylesBorins as a project member who is also a GitHub employee - is the video still up somewhere or there's a blessed equivalent? |
avivkeller
removed
the
fast-track
Member
Understood, I'll take a step back. |
benjamingr
approved these changes
May 14, 2024
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
So, I watched the video at https://web.archive.org/web/20170717015526/https://www.youtube.com/watch?v=HW0RPaJqm4g and it's pretty uesless tbh, I'm fine with removing until there's a better alternative
Lxxyx
approved these changes
May 14, 2024
Trott
approved these changes
May 14, 2024
Flarna
approved these changes
May 14, 2024
MoLow
approved these changes
May 14, 2024
deokjinkim
added
author ready
UlisesGascon
approved these changes
May 15, 2024
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2693f09 |
targos
pushed a commit
that referenced
this pull request
May 21, 2024
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet. PR-URL: #52982 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet. PR-URL: nodejs#52982 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet. PR-URL: nodejs#52982 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet. PR-URL: #52982 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet. PR-URL: #52982 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet.