url: improve isURL performance by adding a typecheck#52832
Closed
avivkeller wants to merge 4 commits intonodejs:mainfrom
Closed
url: improve isURL performance by adding a typecheck#52832avivkeller wants to merge 4 commits intonodejs:mainfrom
avivkeller wants to merge 4 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
anonrig
reviewed
May 4, 2024
jasnell
previously requested changes
May 4, 2024
jasnell
dismissed
their stale review
Issue was addressed while I was leaving the comment
Contributor
|
I think the commit message is wrong (likely adding one check will decrease performance rather than improve it, but in any case it's likely not measurable anyway). I suppose adding this check would help avoid having non-object being accepted as URLs (if someone mutates enough built-in prototypes, literals could be detected as URLs by this util), but if that's a use-case we want to support, we should have a test for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
isURLfunction first verify that the input (self) is an object. This should make the benchmarking time much faster for non-urls, as shown in #52672