Skip to content

fs: allow setting Stats/BigIntStats Date properties#52708

Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom
nicolo-ribaudo:fix-22-stat-regression
Apr 28, 2024
Merged

fs: allow setting Stats/BigIntStats Date properties#52708
nodejs-github-bot merged 5 commits intonodejs:mainfrom
nicolo-ribaudo:fix-22-stat-regression

Conversation

@nicolo-ribaudo
Copy link
Contributor

@nicolo-ribaudo nicolo-ribaudo commented Apr 26, 2024 •
edited
Loading

Fixes #52707, fixes #52705

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Apr 26, 2024
@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft April 26, 2024 13:38
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review April 26, 2024 13:42
@avivkeller
Copy link
Member

avivkeller commented Apr 26, 2024

@nodejs/fs

@nicolo-ribaudo nicolo-ribaudo force-pushed the fix-22-stat-regression branch from e4e20fb to cac9a30 Compare April 26, 2024 13:47
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 26, 2024
Merged
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58718/

@LiviaMedeiros
Copy link
Member

LiviaMedeiros commented Apr 26, 2024

This seems to fix the same bug for BigIntStats, how about a test with { bigint: true }?

@nicolo-ribaudo
Copy link
Contributor Author

nicolo-ribaudo commented Apr 26, 2024

@LiviaMedeiros Done!

@nicolo-ribaudo nicolo-ribaudo changed the title fs: allow setting Stat date properties fs: allow setting Stats/BigIntStats Date properties Apr 26, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58720/

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 26, 2024
Merged
@nicolo-ribaudo
Copy link
Contributor Author

nicolo-ribaudo commented Apr 26, 2024

Could somebody restart CI? :)

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58727/

@zandercymatics
Copy link

zandercymatics commented Apr 26, 2024

@nicolo-ribaudo Thanks for implementing this fix!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 26, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58730/

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2024
@sepehrst
Copy link

sepehrst commented Apr 27, 2024

In addition to the setter, shouldn't ObjectDefineProperty also be retained in the getter (with writable: true, of course)? Otherwise it would remain lazy on repeated access unless it is written to

@nicolo-ribaudo
Copy link
Contributor Author

nicolo-ribaudo commented Apr 27, 2024

The getter calls the setter to define the property (so that the logic doesn't need to be duplicated).

@mcollina mcollina removed the needs-ci PRs that need a full CI run. label Apr 27, 2024
@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1aab22e into nodejs:main Apr 28, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2024

Landed in 1aab22e

@richardlau richardlau added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Apr 28, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the fix-22-stat-regression branch April 28, 2024 16:36
@matz3 matz3 mentioned this pull request Apr 29, 2024
Closed
@allly-b
Copy link

allly-b commented Apr 29, 2024

Hey, any idea when this will make it into a "latest" release? My project is having this gulp issue and I'm wondering if this gets put into a latest release soon we don't have to worry about doing a workaround. Thanks for any update you have!

@mcollina
Copy link
Member

mcollina commented Apr 29, 2024

this will ship in max 2-3 weeks.

@allly-b
Copy link

allly-b commented Apr 29, 2024

Sounds good! Thanks for the quick response!

aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@nicolo-ribaudo @aduh95
fs: allow setting Stat date properties
c6e0fe2 
PR-URL: #52708
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@zandercymatics zandercymatics mentioned this pull request Apr 29, 2024
Closed
2 tasks
@cclauss cclauss mentioned this pull request Apr 30, 2024
Closed
@oddhack oddhack mentioned this pull request Apr 30, 2024
Closed
oddhack added a commit to KhronosGroup/Vulkan-Site that referenced this pull request Apr 30, 2024
@oddhack
Use Node.js 20.12.2 instead of 'latest'
9da3131 
Attempt to work around nodejs/node#52708 /
gulpjs/vinyl-fs#350 by reverting to previous
LTS version.
@oddhack oddhack mentioned this pull request Apr 30, 2024
Merged
oddhack added a commit to KhronosGroup/Vulkan-Site that referenced this pull request Apr 30, 2024
@oddhack
Use Node.js 20.12.2 instead of 'latest' (#83)
b690f5a 
Attempt to work around nodejs/node#52708 /
gulpjs/vinyl-fs#350 by reverting to previous
LTS version.
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@nicolo-ribaudo @eliphazbouye
fs: allow setting Stat date properties
ec97813 
PR-URL: nodejs#52708
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@nicolo-ribaudo @bmeck
fs: allow setting Stat date properties
4a85ae2 
PR-URL: nodejs#52708
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@rluvaton rluvaton rluvaton approved these changes

@avivkeller avivkeller avivkeller approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone