test_runner: hide new line when no error in spec reporter#52297
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Apr 2, 2024
Merged
test_runner: hide new line when no error in spec reporter#52297nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
Author
|
before: after: |
cjihrig
approved these changes
Mar 31, 2024
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with an optional comment.
MoLow
added
the
commit-queue-squash
benjamingr
approved these changes
Apr 1, 2024
MoLow
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
atlowChemi
approved these changes
Apr 1, 2024
Collaborator
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e57992f |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52297 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52297 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems a little nicer to me