doc: document missing options of events.on#52080
Closed
atlowChemi wants to merge 2 commits intonodejs:mainfrom
Closed
doc: document missing options of events.on#52080atlowChemi wants to merge 2 commits intonodejs:mainfrom
atlowChemi wants to merge 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
doc
atlowChemi
force-pushed
the
document-events-on-options
branch
from
01703c3 to
3b693ac
Compare
aymen94
approved these changes
Mar 14, 2024
MoLow
reviewed
Mar 14, 2024
MoLow
reviewed
Mar 14, 2024
atlowChemi
commented
Mar 14, 2024
atlowChemi
added
the
commit-queue-squash
ehmicky
reviewed
Mar 14, 2024
ehmicky
reviewed
Mar 14, 2024
ehmicky
reviewed
Mar 14, 2024
ehmicky
reviewed
Mar 14, 2024
|
Thanks a lot for working on this @atlowChemi, those options are very useful! |
atlowChemi
force-pushed
the
document-events-on-options
branch
from
8f85a99 to
2b844ed
Compare
atlowChemi
added
needs-ci
|
This looks good, thanks @atlowChemi! |
atlowChemi
force-pushed
the
document-events-on-options
branch
from
2b844ed to
ac60b76
Compare
MoLow
approved these changes
Apr 1, 2024
github-actions
bot
removed
the
request-ci
Collaborator
atlowChemi
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
trivikr
approved these changes
Apr 2, 2024
Collaborator
Collaborator
atlowChemi
force-pushed
the
document-events-on-options
branch
from
ac60b76 to
280ab66
Compare
github-actions
bot
removed
the
request-ci
Collaborator
atlowChemi
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52080 ✔ Done loading data for nodejs/node/pull/52080 ----------------------------------- PR info ------------------------------------ Title doc: document missing options of events.on (#52080) Author Chemi Atlow (@atlowChemi) Branch atlowChemi:document-events-on-options -> nodejs:main Labels doc, events, author ready, needs-ci, commit-queue-rebase Commits 2 - events: rename high & low watermark for consistency - doc: document missing options of events.on Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/52080 Fixes: https://github.com/nodejs/node/issues/52078 Refs: https://github.com/nodejs/node/pull/41276 Reviewed-By: Moshe Atlow Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52080 Fixes: https://github.com/nodejs/node/issues/52078 Refs: https://github.com/nodejs/node/pull/41276 Reviewed-By: Moshe Atlow Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - events: rename high & low watermark for consistency ⚠ - doc: document missing options of events.on ℹ This PR was created on Thu, 14 Mar 2024 08:03:36 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52080#pullrequestreview-1972026393 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/52080#pullrequestreview-1972637799 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-04T14:50:00Z: https://ci.nodejs.org/job/node-test-pull-request/58118/ - Querying data for job/node-test-pull-request/58118/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8570189085 |
nodejs-github-bot
added
the
commit-queue-failed
MoLow
approved these changes
Apr 5, 2024
atlowChemi
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ec15504...d0c364a |
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52078
Refs: #41276