Revert "test_runner: do not invoke after hook when test is empty"#51998
Closed
cjihrig wants to merge 2 commits intonodejs:mainfrom
Closed
Revert "test_runner: do not invoke after hook when test is empty"#51998cjihrig wants to merge 2 commits intonodejs:mainfrom
cjihrig wants to merge 2 commits intonodejs:mainfrom
Conversation
This reverts commit a53fd95. This caused a regression because the original issue this commit was attempting to fix is not a bug. The after() hook should always run. Fixes: nodejs#51997
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
cjihrig
changed the title
KhafraDev
approved these changes
Mar 7, 2024
richardlau
approved these changes
Mar 7, 2024
github-actions
bot
removed
the
request-ci
Collaborator
MoLow
approved these changes
Mar 7, 2024
Collaborator
aduh95
added
author ready
mcollina
added
the
commit-queue-rebase
marco-ippolito
approved these changes
Mar 7, 2024
Member
|
Should we make a quick release to fix this regression? |
Member
|
That'd be really useful, thanks. |
Contributor
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
targos
approved these changes
Mar 7, 2024
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 4f3cf4e...3aa0658 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
This reverts commit a53fd95. This caused a regression because the original issue this commit was attempting to fix is not a bug. The after() hook should always run. Fixes: #51997 PR-URL: #51998 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Refs: #51997 PR-URL: #51998 Fixes: #51997 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 7, 2024
This reverts commit a53fd95. This caused a regression because the original issue this commit was attempting to fix is not a bug. The after() hook should always run. Fixes: #51997 PR-URL: #51998 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 7, 2024
Refs: #51997 PR-URL: #51998 Fixes: #51997 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This was referenced Mar 7, 2024
Member
|
Sorry for the regression 😢🙏🏻 |
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Refs: #51997 PR-URL: #51998 Fixes: #51997 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Refs: #51997 PR-URL: #51998 Fixes: #51997 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This reverts commit a53fd95. This caused a regression because the original issue this commit was attempting to fix is not a bug. The after() hook should always run. Fixes: nodejs#51997 PR-URL: nodejs#51998 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Refs: nodejs#51997 PR-URL: nodejs#51998 Fixes: nodejs#51997 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jcbhmr
pushed a commit
to jcbhmr/node
that referenced
this pull request
May 15, 2024
This reverts commit a53fd95. This caused a regression because the original issue this commit was attempting to fix is not a bug. The after() hook should always run. Fixes: nodejs#51997 PR-URL: nodejs#51998 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jcbhmr
pushed a commit
to jcbhmr/node
that referenced
this pull request
May 15, 2024
Refs: nodejs#51997 PR-URL: nodejs#51998 Fixes: nodejs#51997 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
added
dont-land-on-v18.x
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51997