Skip to content

test: reduce flakiness of test-runner-output#51952

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
aduh95:test-runner-output
Mar 5, 2024
Merged

test: reduce flakiness of test-runner-output#51952
nodejs-github-bot merged 2 commits intonodejs:mainfrom
aduh95:test-runner-output

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 3, 2024

It was failing 1% of the times on my local machine. With that patch, I got no failures on 1000 runs.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 3, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 3, 2024
aduh95
aduh95 commented Mar 3, 2024
View reviewed changes
aduh95
aduh95 commented Mar 3, 2024
View reviewed changes
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57569/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57571/

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 16579d7 into nodejs:main Mar 5, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 5, 2024

Landed in 16579d7

@aduh95 aduh95 deleted the test-runner-output branch March 5, 2024 21:38
targos pushed a commit that referenced this pull request Mar 7, 2024
@aduh95 @targos
test: reduce flakiness of test-runner-output
fff7f48 
PR-URL: #51952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Mar 7, 2024
Merged
cjihrig added a commit to cjihrig/node that referenced this pull request Mar 18, 2024
@cjihrig
test: reduce flakiness of test-runner-output.mjs
21c7305 
This commit is similar to nodejs#51952. When the system is under load
it is possible for these timeout tests to become flaky. We
work around that by using a much longer setTimeout() in the test
so that it is not racing against the test's timeout. But, we have
to unref() such a large timeout. And, because test timeouts do
not currently keep the event loop alive, we use a different
setTimeout() for that purpose.

Fixes: nodejs#52139
Refs: nodejs#52140
This was referenced Mar 18, 2024
Merged
Closed
nodejs-github-bot pushed a commit that referenced this pull request Mar 19, 2024
@cjihrig
test: reduce flakiness of test-runner-output.mjs
978d5a2 
This commit is similar to #51952. When the system is under load
it is possible for these timeout tests to become flaky. We
work around that by using a much longer setTimeout() in the test
so that it is not racing against the test's timeout. But, we have
to unref() such a large timeout. And, because test timeouts do
not currently keep the event loop alive, we use a different
setTimeout() for that purpose.

Fixes: #52139
Refs: #52140
PR-URL: #52146
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aduh95 @richardlau
test: reduce flakiness of test-runner-output
09a648d 
PR-URL: #51952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aduh95 @richardlau
test: reduce flakiness of test-runner-output
60f008b 
PR-URL: #51952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@aduh95 @rdw-msft
test: reduce flakiness of test-runner-output
437f4e6 
PR-URL: nodejs#51952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@cjihrig @rdw-msft
test: reduce flakiness of test-runner-output.mjs
e9e6edc 
This commit is similar to nodejs#51952. When the system is under load
it is possible for these timeout tests to become flaky. We
work around that by using a much longer setTimeout() in the test
so that it is not racing against the test's timeout. But, we have
to unref() such a large timeout. And, because test timeouts do
not currently keep the event loop alive, we use a different
setTimeout() for that purpose.

Fixes: nodejs#52139
Refs: nodejs#52140
PR-URL: nodejs#52146
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@cjihrig @marco-ippolito
test: reduce flakiness of test-runner-output.mjs
3a75341 
This commit is similar to #51952. When the system is under load
it is possible for these timeout tests to become flaky. We
work around that by using a much longer setTimeout() in the test
so that it is not racing against the test's timeout. But, we have
to unref() such a large timeout. And, because test timeouts do
not currently keep the event loop alive, we use a different
setTimeout() for that purpose.

Fixes: #52139
Refs: #52140
PR-URL: #52146
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@cjihrig @marco-ippolito
test: reduce flakiness of test-runner-output.mjs
d7bfb4e 
This commit is similar to #51952. When the system is under load
it is possible for these timeout tests to become flaky. We
work around that by using a much longer setTimeout() in the test
so that it is not racing against the test's timeout. But, we have
to unref() such a large timeout. And, because test timeouts do
not currently keep the event loop alive, we use a different
setTimeout() for that purpose.

Fixes: #52139
Refs: #52140
PR-URL: #52146
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95 @nodejs-github-bot @lpinca @tniessen @MoLow @atlowChemi