Update install.py

[Avinash-Raj]

-> Why I have changed s = re.sub(r'#.*?\n', '', s) to s = re.sub(r'#.*\n?', '', s)?

Because your regex won't match the comment line which exists at the last (End of a file) because it expects a newline character . But s = re.sub(r'#.*\n?', '', s) should remove all the comment lines irrespective of their locations. .*? -> .* because dot by default won't match line breaks.

-> A simple string.replace should do this re.sub(r'\'', '"', s) job, you don't need to go for `re.sub

If you want to further reduce these two lines of code into a single line then go with this,

re.sub(r"#.*\n?|(')", lambda x: '"' if x.group(1) else '', s)

[rvagg]

Is there a particular case you have where there is a comment at the bottom of the file? The change lgtm and seems more correct (.*? is pretty amusing) but I'm wondering if it's addressing an actual problem.

[Fishrock123]

Closing, @Avinash-Raj if you can show somewhere that could be affected by this we'll re-open. :)