deps: add deprecation warning for import assertion syntax#51631
Closed
aduh95 wants to merge 2 commits intonodejs:mainfrom
Closed
deps: add deprecation warning for import assertion syntax#51631aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95 wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Original commit message:
[import-attributes] Deprecate 'assert' for removal in 12.6
See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ
Bug: v8:10958
Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#92044}
Refs: v8/v8@ae5a4db
Original commit message:
[import-attributes] Deprecate 'assert' for dynamic import as well
Bug: v8:10958
Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#92123}
Refs: v8/v8@26fd1df
d56a4be to
545a983
Compare
Member
I think "in a future version" or "12.6 of V8" would be better to use if its ok to float a patch for this or maybe a upstream v8 patch to say "12.6 of V8" |
Contributor
Author
|
/cc @nodejs/v8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what the semverness of this would be, hopefully we can backport it to v18.x if #51136 can land there. Here's what the warning looks like:
Should we mutate the V8 warning to say "in a future version" instead of "in 12.6"?
Refs: #51622