tools: fix loong64 build

[shipujin]

tools: fix loong64 build

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/v8-update

[targos]

Another condition on line 972 should be enough.

[shipujin]

Another condition on line 972 should be enough.

Ok, what you said is right. I will modify patch and submit again

[targos]

I still think the patch could be simpler with only a change on line 972.

[shipujin]

line 972

I don't quite understand what you mean. Do you mean that only 972 can be modified?

diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index 4d69a59fcb..79e1256fe8 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -969,7 +969,7 @@
           'conditions': [
             ['v8_enable_webassembly==1', {
               'conditions': [
-                ['((_toolset=="host" and host_arch=="arm64" or _toolset=="target" and target_arch=="arm64") and (OS=="linux" or OS=="mac" or OS=="ios")) or ((_toolset=="host" and host_arch=="x64" or _toolset=="target" and target_arch=="x64") and (OS=="linux" or OS=="mac"))', {
+                ['((_toolset=="host" and host_arch=="arm64" or _toolset=="target" and target_arch=="arm64") and (OS=="linux" or OS=="mac" or OS=="ios")) or ((_toolset=="host" and host_arch=="x64" or _toolset=="target" and target_arch=="x64") and (OS=="linux" or OS=="mac")) or ((_toolset=="host" and host_arch=="loong64" or _toolset=="target" and target_arch=="loong64") and (OS=="linux" or OS=="mac"))', {
                   'sources': [
                     '<(V8_ROOT)/src/trap-handler/handler-inside-posix.cc',
                     '<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',

Line 972 is in the range of v8_target_arch=="arm64". Modifying only line 972 will continue to report an error

Best regards

[targos]

Oh, yes you're right, sorry about that! I guess you can still simplify it a bit by removing the various OS=="mac" and OS=="ios" conditions, but LGTM.

[shipujin]

Oh, yes you're right, sorry about that! I guess you can still simplify it a bit by removing the various OS=="mac" and OS=="ios" conditions, but LGTM.

You're right. I can remove the Mac-related stuff and simplify, I will resubmit.

Best regards

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56724/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5761/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5761/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5761/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56753/

[nodejs-github-bot]

Landed in 6ae20aa