Load data url with search correctly#51324
Closed
LongTengDao wants to merge 4 commits intonodejs:mainfrom
Closed
Conversation
Collaborator
|
Review requested:
|
Member
|
Compatibility aside, this looks more like a bug in browsers to me. > import('data:text/javascript,console.log(new URL(import.meta.url).hash);#123')
#123
> import('data:text/javascript;base64,Y29uc29sZS5sb2cobmV3IFVSTChpbXBvcnQubWV0YS51cmwpLmhhc2gpOw==#123')
#123
> import('data:text/javascript,console.log(new URL(import.meta.url).search);?123')
SyntaxError: Unexpected token '?'
> import('data:text/javascript;base64,Y29uc29sZS5sb2cobmV3IFVSTChpbXBvcnQubWV0YS51cmwpLnNlYXJjaCk7?123')
TypeError: Failed to fetch dynamically imported module
> import(`data:text/javascript,console.log('#');`);
SyntaxError: Invalid or unexpected tokenIf pathname is properly urlencoded (which should be the case whenever we work with URLs), it works just fine: > import(`data:text/javascript,console.log('%3F');#...`);
? |
Contributor
Author
|
I'm a framework author, and I also wanted to find any spec, then failed. But under my test and analysis, it rarely seems like a bug of browsers, because:
Even if nodejs does not want to respect the hash, it should at least throw an error, not silently run a code trimmed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works in browsers (firefox, safari, even chrome):