[v20.x backport] win,tools: upgrade Windows signing to smctl#51116
[v20.x backport] win,tools: upgrade Windows signing to smctl#51116StefanStojanovic wants to merge 1 commit intonodejs:v20.x-stagingfrom
Conversation
As a part of the new signing requrements for Windows change approach to use the DigiCert cloud HSM service KeyLocker. PR-URL: nodejs#50956 Fixes: nodejs/build#3491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
StefanStojanovic
changed the title
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
@nodejs/releasers It's possible the original commit will cherry-pick cleanly but I'm approving this backport in case it doesn't and we need to land before the usual "two weeks in current".
Please note that the Windows signing certificate we have been using expires on 18 December 2023 (nodejs/build#3491) so any new releases should include this PR so that they start using the new certificate.
This was created by cherry-pick, so it should work. I wasn't aware of any policy for backporting commits to LTS branches, so I opened this PR. In case there is another way feel free to let me know how I should do it. Thanks in advance. |
UlisesGascon
force-pushed
the
v20.x-staging
branch
from
423c757 to
fd4149d
Compare
UlisesGascon
force-pushed
the
v20.x-staging
branch
2 times, most recently
from
4c9099f to
7af8e20
Compare
UlisesGascon
force-pushed
the
v20.x-staging
branch
from
a42629c to
435f9c9
Compare
|
Since this change was already ported in #51124, I'm closing this PR. |
3 participants
As a part of the new signing requirements for Windows, this changes the approach to using the DigiCert cloud HSM service KeyLocker. This change already landed on the main branch in this PR. This is just a port to the LTS version needed for future releases.
Refs: nodejs/build#3491