Merged
Conversation
nodejs-github-bot
added
dependencies
targos
force-pushed
the
actions/tools-update-brotli
branch
from
a6ad5ec to
e521913
Compare
Member
|
Just rebased, fixed the conflict and updated the gyp file. |
github-actions
bot
removed
the
request-ci
Collaborator
Author
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in 5e64483 |
Contributor
|
Clueless question from the peanut gallery: is this kind of change typically okay to backport to LTS? We have some compression-intensive workloads on 20.x where the supposed ~5% performance improvement included in this upgrade would be appreciated. |
Member
Yes, it will be backported. |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Jan 4, 2024
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 7, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: nodejs#51373 Refs: nodejs#50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: nodejs#51373 Refs: nodejs#50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
added a commit
that referenced
this pull request
Mar 25, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
added a commit
that referenced
this pull request
Mar 25, 2024
Update `tools/dep_updaters/update-brotli.sh` to parse the current version of brotli from the newer macros `BROTLI_VERSION_MAJOR`, `BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`. PR-URL: #51373 Refs: #50804 Refs: nodejs/security-wg#1181 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
aduh95
pushed a commit
that referenced
this pull request
Nov 3, 2024
PR-URL: #50804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of brotli to 1.1.0.