benchmark: update iterations in benchmark/util/splice-one.js#50698
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Nov 26, 2023
Merged
benchmark: update iterations in benchmark/util/splice-one.js#50698nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: nodejs#50571
H4ad
approved these changes
Nov 17, 2023
Collaborator
Collaborator
Collaborator
|
Landed in f8c27e6 |
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: nodejs#50571 PR-URL: nodejs#50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: nodejs#50571 PR-URL: nodejs#50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #50571
In case
util/splice-one.js, when onlypos=endI found that the performance gap between node-21.x and node-20.x increased from -15% to 5% after I changed iterations from default1e5to5e6. (node-20.x is the baseline.)To make sure there was no problem with this modification, I tested the other 8 situations in this case (there are 9 situations in total, 3 types of
pos, 3 types ofsize).Here is the tests data and the new binary is
node 21.x.node-21.x vs node-20.x