deps: update cjs-module-lexer to 1.4.0#50458
Closed
nodejs-github-bot wants to merge 4 commits intomainfrom
Closed
Conversation
8272d33 to
403c144
Compare
Member
|
@nodejs/loaders (I assume this is related to loaders), this update breaks the build |
Contributor
|
This update was reverted - nodejs/cjs-module-lexer#95. Unless progress is made on the PR in nodejs/cjs-module-lexer#98, it will be published with the revert. |
This comment has been minimized.
This comment has been minimized.
marco-ippolito
approved these changes
Sep 1, 2024
Member
|
The build still looks broken. |
Member
|
Contributor
|
I just cloned this branch, built and tested locally, and all seems to be working fine to me. Let me know if I can assist further. |
Member
|
Let's try to recreate from scratch |
Member
Contributor
|
Thanks @targos I'm building and testing on Windows so it seems like it's working fine on Windows. I can try a build on my work machine tomorrow if it helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of cjs-module-lexer to 1.4.0.