stream,doc: make writable.setDefaultEncoding() return this#5040
Merged
calvinmetcalf merged 1 commit intonodejs:masterfrom Apr 30, 2016
estliberitas:stream-return-this
Merged
stream,doc: make writable.setDefaultEncoding() return this#5040calvinmetcalf merged 1 commit intonodejs:masterfrom estliberitas:stream-return-this
writable.setDefaultEncoding() return this#5040calvinmetcalf merged 1 commit intonodejs:masterfrom
estliberitas:stream-return-this
Conversation
Contributor
|
LGTM |
cjihrig
added
stream
Contributor
|
LGTM |
Member
Contributor
|
Wouldn't this be |
Contributor
|
I guess it's debatable. I gave it semver-minor because it's adding a return type where one didn't exist before, but I can definitely see the argument for semver-major. I don't have a strong opinion. |
Contributor
|
I know we landed some changes like this previously for net (#1768). They were landed as semver-minor, but I don't really have a strong opinion here either. |
Member
|
Since it never returned a value previously there shouldn't be anyone depending on that return value ;-) ... it's likely safe as a semver-minor. |
Member
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4 to
c7066fb
Compare
Member
|
New New CI since this didn't land before: https://ci.nodejs.org/job/node-test-pull-request/2419/ |
Contributor
Author
|
I guess, first I have to resolve conflicts |
Let this function return `this` for parity with `readable.setEncoding()` (#5013).
Contributor
Author
|
@jasnell OS X build failed on test-tick-processor and I guess it's not relevant? |
Member
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/2442/ |
Member
|
CI is green. |
Member
|
@nodejs/streams ... any objections to this one? |
Member
|
LGTM |
Contributor
|
LGTM 👍 |
This was referenced May 4, 2016
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
Let this function return `this` for parity with `readable.setEncoding()`. PR-URL: nodejs#5040 Fixes: nodejs#5013 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
added a commit
that referenced
this pull request
May 5, 2016
* assert: `deep{Strict}Equal()` now works correctly with circular
references. (Rich Trott) #6432
* debugger: Arrays are now formatted correctly in the debugger repl.
(cjihrig) #6448
* deps: Upgrade OpenSSL sources to 1.0.2h (Shigeki Ohtsu)
#6550
* net: Introduced a `Socket#connecting` property. (Fedor Indutny)
#6404
- Previously this information was only available as the undocumented,
internal `_connecting` property.
* process: Introduced `process.cpuUsage()`. (Patrick Mueller)
#6157
* stream: `Writable#setDefaultEncoding()` now returns `this`.
(Alexander Makarenko) #5040
* util: Two new additions to `util.inspect()`:
- Added a `maxArrayLength` option to truncate the formatting of
Arrays. (James M Snell) #6334
- This is set to `100` by default.
- Added a `showProxy` option for formatting proxy intercepting
handlers. (James M Snell) #6465
- Inspecting proxies is non-trivial and as such this is off by
default.
PR-URL: #6557
Fishrock123
added a commit
that referenced
this pull request
May 5, 2016
* assert: `deep{Strict}Equal()` now works correctly with circular
references. (Rich Trott) #6432
* debugger: Arrays are now formatted correctly in the debugger repl.
(cjihrig) #6448
* deps: Upgrade OpenSSL sources to 1.0.2h (Shigeki Ohtsu)
#6550
- Please see our blog post for more info on the security contents of this release:
- https://nodejs.org/en/blog/vulnerability/openssl-may-2016/
* net: Introduced a `Socket#connecting` property. (Fedor Indutny)
#6404
- Previously this information was only available as the undocumented,
internal `_connecting` property.
* process: Introduced `process.cpuUsage()`. (Patrick Mueller)
#6157
* stream: `Writable#setDefaultEncoding()` now returns `this`.
(Alexander Makarenko) #5040
* util: Two new additions to `util.inspect()`:
- Added a `maxArrayLength` option to truncate the formatting of
Arrays. (James M Snell) #6334
- This is set to `100` by default.
- Added a `showProxy` option for formatting proxy intercepting
handlers. (James M Snell) #6465
- Inspecting proxies is non-trivial and as such this is off by
default.
PR-URL: #6557
Fishrock123
added a commit
that referenced
this pull request
May 5, 2016
* assert: `deep{Strict}Equal()` now works correctly with circular
references. (Rich Trott) #6432
* debugger: Arrays are now formatted correctly in the debugger repl.
(cjihrig) #6448
* deps: Upgrade OpenSSL sources to 1.0.2h (Shigeki Ohtsu)
#6550
- Please see our blog post for more info on the security contents of
this release:
- https://nodejs.org/en/blog/vulnerability/openssl-may-2016/
* net: Introduced a `Socket#connecting` property. (Fedor Indutny)
#6404
- Previously this information was only available as the undocumented,
internal `_connecting` property.
* process: Introduced `process.cpuUsage()`. (Patrick Mueller)
#6157
* stream: `Writable#setDefaultEncoding()` now returns `this`.
(Alexander Makarenko) #5040
* util: Two new additions to `util.inspect()`:
- Added a `maxArrayLength` option to truncate the formatting of
Arrays. (James M Snell) #6334
- This is set to `100` by default.
- Added a `showProxy` option for formatting proxy intercepting
handlers. (James M Snell) #6465
- Inspecting proxies is non-trivial and as such this is off by
default.
PR-URL: #6557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let this function return
thisfor parity withreadable.setEncoding()though they set encodings for different purposes. (#5013).