tools: update gyp-next to v0.16.1 by targos · Pull Request #50380 · nodejs/node

targos · 2023-10-25T06:43:42Z

No description provided.

nodejs-github-bot · 2023-10-25T06:43:47Z

Review requested:

@nodejs/gyp

targos · 2023-10-25T06:50:20Z

@nodejs/python not sure what to do about https://github.com/nodejs/node/actions/runs/6636731539/job/18029693061

gengjiawen · 2023-10-25T07:07:13Z

@nodejs/python not sure what to do about nodejs/node/actions/runs/6636731539/job/18029693061

ignore tools/gyp should do.

node/pyproject.toml

Line 23 in d1ccca9

"tools/node_modules",

cclauss · 2023-10-25T07:14:21Z

I would comment out this line in tools/gyp/pyproject.toml
error: TOML parse error at line 94, column 3
|
94 | "PLR1714",
| ^^^^^^^^^
Unknown rule selector: PLR1714

gengjiawen · 2023-10-25T07:16:04Z

I would comment out this line: error: TOML parse error at line 94, column 3 | 94 | "PLR1714", | ^^^^^^^^^ Unknown rule selector: PLR1714

In the long run, we shouldn't lint and format deps in Node.js repo. This can be done in gyp-next.

cclauss · 2023-10-25T07:17:50Z

Oh... This is because we are using a pinned version of ruff and gyp-next is using a current one.

cclauss · 2023-10-25T07:19:01Z

Please update

node/Makefile

Lines 1499 to 1500 in d1ccca9

    
           $(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff==0.0.272 || \ 
        
           	$(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff==0.0.272

nodejs-github-bot · 2023-10-25T07:19:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55218/

targos · 2023-10-25T07:20:19Z

This should not be related. gyp-next is linted in its own project and I agree with @gengjiawen we should not lint it again with our own rules here.

cclauss · 2023-10-25T08:49:49Z

Ruff is designed to work in complex monorepos so we would not be testing the node-gyp directory using this repo’s pyproject.toml (as this error proves). Ruff parsed this file because it will be the settings used to lint that directory.

nodejs-github-bot · 2023-10-31T12:44:40Z

Landed in a77ef54...6557c1c

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs/node#50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 25, 2023

targos added 2 commits October 25, 2023 09:10

tools: skip ruff on tools/gyp

a723950

tools: update gyp-next to v0.16.1

4c784ef

targos force-pushed the update-gyp branch from 003bb7b to 4c784ef Compare October 25, 2023 07:10

gengjiawen approved these changes Oct 25, 2023

View reviewed changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023

jasnell approved these changes Oct 28, 2023

View reviewed changes

anonrig approved these changes Oct 31, 2023

View reviewed changes

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Oct 31, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2023

nodejs-github-bot closed this Oct 31, 2023

nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023

tools: skip ruff on tools/gyp

76d4e38

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023

tools: update gyp-next to v0.16.1

6557c1c

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos deleted the update-gyp branch October 31, 2023 12:45

This was referenced Nov 6, 2023

build: support Python 3.12 #50209

Merged

build: fix build with Python 3.12 #50582

Merged

anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023

tools: skip ruff on tools/gyp

e23d836

PR-URL: nodejs#50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023

tools: update gyp-next to v0.16.1

7478b77

PR-URL: nodejs#50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos added a commit that referenced this pull request Nov 11, 2023

tools: skip ruff on tools/gyp

de9dc10

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos added a commit that referenced this pull request Nov 11, 2023

tools: update gyp-next to v0.16.1

171ae59

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos mentioned this pull request Nov 12, 2023

v21.2.0 release proposal #50681

Merged

targos added a commit that referenced this pull request Nov 14, 2023

tools: skip ruff on tools/gyp

9fc29c9

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos added a commit that referenced this pull request Nov 14, 2023

tools: update gyp-next to v0.16.1

52e7b6d

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos added lts-watch-v18.x lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 15, 2023

UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023

tools: skip ruff on tools/gyp

f5ccab5

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023

tools: update gyp-next to v0.16.1

22b7a74

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

UlisesGascon mentioned this pull request Dec 12, 2023

v20.11.0 proposal #51124

Merged

richardlau mentioned this pull request Mar 22, 2024

ansible: upgrade test-digitalocean-fedora32-x64-1 nodejs/build#3660

Merged

richardlau added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 25, 2024

aduh95 pushed a commit that referenced this pull request Nov 2, 2024

tools: skip ruff on tools/gyp

fa72b2c

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request Nov 2, 2024

tools: update gyp-next to v0.16.1

0fb652e

PR-URL: #50380 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 added backported-to-v18.x and removed lts-watch-v18.x labels Nov 2, 2024

aduh95 mentioned this pull request Nov 7, 2024

2024-11-12, Version 18.20.5 'Hydrogen' (LTS) #55768

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tools: update gyp-next to v0.16.1#50380

tools: update gyp-next to v0.16.1#50380
targos wants to merge 2 commits intonodejs:mainfrom
targos:update-gyp

targos commented Oct 25, 2023

Uh oh!

nodejs-github-bot commented Oct 25, 2023

Uh oh!

targos commented Oct 25, 2023

Uh oh!

gengjiawen commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023 •

edited

Loading

Uh oh!

gengjiawen commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023

Uh oh!

nodejs-github-bot commented Oct 25, 2023

Uh oh!

targos commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023 •

edited

Loading

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

targos commented Oct 25, 2023

Uh oh!

nodejs-github-bot commented Oct 25, 2023

Uh oh!

targos commented Oct 25, 2023

Uh oh!

gengjiawen commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023

Uh oh!

nodejs-github-bot commented Oct 25, 2023

Uh oh!

targos commented Oct 25, 2023

Uh oh!

cclauss commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cclauss commented Oct 25, 2023 •

edited

Loading

cclauss commented Oct 25, 2023 •

edited

Loading