tools: run coverage CI only on relevant files#50349
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Oct 25, 2023
Merged
tools: run coverage CI only on relevant files#50349nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
richardlau
reviewed
Oct 23, 2023
Comment on lines
6
to
11
| paths: | ||
| - lib/**/*.js | ||
| - src/**/*.cc | ||
| - src/**/*.h | ||
| - test/**/* | ||
| - .github/workflows/coverage-linux.yml |
Member
There was a problem hiding this comment.
Theoretically changes to the Python test runner and/or build files (Makefile, gyp files) could also affect coverage results.
anonrig
approved these changes
Oct 24, 2023
richardlau
approved these changes
Oct 24, 2023
bnb
approved these changes
Oct 25, 2023
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 69c0571 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it makes sense to restrict run of coverage jobs only on files that can affect its result, so that's what this PR is trying to do.