Skip to content

test: set inspector async stack test as flaky#50244

Closed
anonrig wants to merge 1 commit intonodejs:mainfrom
anonrig:test-inspector-async-stack-traces-set-interval
Closed

test: set inspector async stack test as flaky#50244
anonrig wants to merge 1 commit intonodejs:mainfrom
anonrig:test-inspector-async-stack-traces-set-interval

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Oct 18, 2023

Ref: #50243

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54949/

@anonrig anonrig added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54962/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54979/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54985/

@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54986/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55014/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/55027/

@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Open
20 tasks
mhdawson
mhdawson approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Oct 20, 2023
@anonrig @mhdawson
test: set inspector async stack test as flaky
35becbc 
#50243
PR-URL: #50244
Refs: #50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member

mhdawson commented Oct 20, 2023

Landed in 35becbc

@mhdawson mhdawson closed this Oct 20, 2023
This was referenced Oct 21, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig @targos
test: set inspector async stack test as flaky
57adbdd 
#50243
PR-URL: #50244
Refs: #50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
test: set inspector async stack test as flaky
896f2e2 
nodejs#50243
PR-URL: nodejs#50244
Refs: nodejs#50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
test: set inspector async stack test as flaky
50181a1 
#50243
PR-URL: #50244
Refs: #50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
test: set inspector async stack test as flaky
91a3b57 
#50243
PR-URL: #50244
Refs: #50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set inspector async stack test as flaky
842d401 
nodejs/node#50243
PR-URL: nodejs/node#50244
Refs: nodejs/node#50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set inspector async stack test as flaky
7bfdf8a 
nodejs/node#50243
PR-URL: nodejs/node#50244
Refs: nodejs/node#50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@panva panva panva approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig @nodejs-github-bot @mhdawson @ruyadorno @panva