[v18.x backport] test: fix edge snapshot stack traces#50237
Closed
codebytere wants to merge 1 commit intonodejs:v18.x-stagingfrom
Closed
[v18.x backport] test: fix edge snapshot stack traces#50237codebytere wants to merge 1 commit intonodejs:v18.x-stagingfrom
codebytere wants to merge 1 commit intonodejs:v18.x-stagingfrom
Conversation
nodejs-github-bot
added
needs-ci
codebytere
force-pushed
the
backport-message-tests-18
branch
from
6aeb5d7 to
57814ae
Compare
4 tasks
PR-URL: nodejs#49659 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
codebytere
force-pushed
the
backport-message-tests-18
branch
from
57814ae to
fc6fe0f
Compare
MoLow
approved these changes
Oct 19, 2023
codebytere
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
This was referenced Nov 3, 2023
Member
|
Thanks, the commit is now part of #50669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #49659 - it's affecting Electron in 18 and it'd help us a fair bit for this to land.