fs: add flush option to writeFile() functions by cjihrig · Pull Request #50009 · nodejs/node

cjihrig · 2023-10-02T03:57:40Z

This commit adds a 'flush' option to the fs.writeFile family of functions.

Notable change summary: When writing to files, it is possible that data is not immediately flushed to permanent storage. This allows subsequent read operations to see stale data. This PR adds a 'flush' option to the fs.writeFile family of functions which forces the data to be flushed at the end of a successful write operation.

This commit adds a 'flush' option to the fs.writeFile family of functions. Refs: nodejs#49886

mcollina

lgtm

nodejs-github-bot · 2023-10-02T09:18:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54456/

nodejs-github-bot · 2023-10-03T03:38:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54482/

nodejs-github-bot · 2023-10-03T04:35:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54483/ 🟢

mcollina

lgtm

github-actions · 2023-10-04T07:44:15Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @mcollina.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

nodejs-github-bot · 2023-10-04T13:10:32Z

Landed in e01c1d7

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in nodejs#50009, but this makes it more official. Refs: nodejs#49886 Refs: nodejs#50009 PR-URL: nodejs#50095 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This commit adds a 'flush' option to the fs.writeFile family of functions. Refs: #49886 PR-URL: #50009 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

This commit adds documentation and tests for the 'flush' option of the fs.appendFile family of functions. Technically, support was indirectly added in #50009, but this makes it more official. Refs: #49886 Refs: #50009 PR-URL: #50095 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 doc: * add H4ad to collaborators (Vinícius Lourenço) #50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096 * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095 * add flush option to writeFile() functions (Colin Ihrig) #50009 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187 * call helper function from push and unshift (Raz Luvaton) #50173 * optimize Writable (Robert Nagy) #50012 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 wasi: PR-URL: #50682

In nodejs#50009, the return value was accidentally made part of `flush` option bullet point.

In #50009, the return value was accidentally made part of `flush` option bullet point. PR-URL: #50760 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 doc: * add H4ad to collaborators (Vinícius Lourenço) #50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096 * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095 * add flush option to writeFile() functions (Colin Ihrig) #50009 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187 * call helper function from push and unshift (Raz Luvaton) #50173 * optimize Writable (Robert Nagy) #50012 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 wasi: PR-URL: #50682

In #50009, the return value was accidentally made part of `flush` option bullet point. PR-URL: #50760 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

In nodejs#50009, the return value was accidentally made part of `flush` option bullet point. PR-URL: nodejs#50760 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908 doc: * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096 * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095 * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187 * call helper function from push and unshift (Raz Luvaton) nodejs#50173 * optimize Writable (Robert Nagy) nodejs#50012 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141 * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950 wasi: PR-URL: nodejs#50682

In nodejs#50009, the return value was accidentally made part of `flush` option bullet point. PR-URL: nodejs#50760 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908 doc: * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217 esm: * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096 * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869 fs: * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095 * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830 stream: * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187 * call helper function from push and unshift (Raz Luvaton) nodejs#50173 * optimize Writable (Robert Nagy) nodejs#50012 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141 * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950 wasi: PR-URL: nodejs#50682

In #50009, the return value was accidentally made part of `flush` option bullet point. PR-URL: #50760 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

This commit adds a 'flush' option to the fs.writeFile family of functions. Refs: nodejs#49886 PR-URL: nodejs#50009 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

hhjmmmmmmmm · 2024-05-02T07:37:09Z

lib/fs.js

@@ -2217,7 +2217,7 @@ function lutimesSync(path, atime, mtime) {
  handleErrorFromBinding(ctx);


docker pull python

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 2, 2023

fs: add flush option to writeFile() functions

ad3a583

This commit adds a 'flush' option to the fs.writeFile family of functions. Refs: nodejs#49886

cjihrig force-pushed the auto-sync branch from 9712839 to ad3a583 Compare October 2, 2023 03:58

mcollina approved these changes Oct 2, 2023

View reviewed changes

targos approved these changes Oct 2, 2023

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023

LiviaMedeiros approved these changes Oct 2, 2023

View reviewed changes

github-actions bot mentioned this pull request Oct 3, 2023

CI Reliability 2023-10-03 nodejs/reliability#682

Open

18 tasks

run make format-md

78ab583

watilde approved these changes Oct 3, 2023

View reviewed changes

cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 3, 2023

mcollina approved these changes Oct 3, 2023

View reviewed changes

anonrig added the needs-ci PRs that need a full CI run. label Oct 3, 2023

github-actions bot mentioned this pull request Oct 4, 2023

CI Reliability 2023-10-04 nodejs/reliability#683

Open

14 tasks

mcollina added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 4, 2023

cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Oct 4, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2023

nodejs-github-bot merged commit e01c1d7 into nodejs:main Oct 4, 2023

cjihrig deleted the auto-sync branch October 4, 2023 13:10

github-actions bot mentioned this pull request Oct 5, 2023

CI Reliability 2023-10-05 nodejs/reliability#684

Open

13 tasks

targos mentioned this pull request Nov 12, 2023

v20.10.0 release proposal #50682

Merged

RyanZim added a commit to RyanZim/node that referenced this pull request Nov 16, 2023

doc: fix fs.writeFileSync return value documentation

81c4301

In nodejs#50009, the return value was accidentally made part of `flush` option bullet point.

RyanZim mentioned this pull request Nov 16, 2023

doc: fix fs.writeFileSync return value documentation #50760

Merged

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

boenrobot mentioned this pull request Dec 29, 2023

refactor: use flush option with writeFile mikro-orm/mikro-orm#5058

Merged

hhjmmmmmmmm reviewed May 2, 2024

View reviewed changes

lib/fs.js

@@ -2217,7 +2217,7 @@ function lutimesSync(path, atime, mtime) {

handleErrorFromBinding(ctx);

Copy link

hhjmmmmmmmm May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker pull python

gibson042 mentioned this pull request Sep 15, 2024

CI sometimes fails to read swingset config file Agoric/agoric-sdk#10092

Closed

WULCAN mentioned this pull request Mar 15, 2025

Writes are not flushed before subsequent read zetkin/lyra#162

Closed

amerharb mentioned this pull request Mar 15, 2025

Undocumented use flush option in fs.writeFile() zetkin/lyra#163

Merged

WULCAN mentioned this pull request Mar 29, 2025

Implemented Containerization of the Lyra Webapp zetkin/lyra#157

Merged

This was referenced Nov 2, 2025

fs: flush option ignored when writing/appending strings #60552

Open

fs: add c++ fast path for writeFileSync string utf8 #49884

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fs: add flush option to writeFile() functions#50009

fs: add flush option to writeFile() functions#50009
nodejs-github-bot merged 2 commits intonodejs:mainfrom
cjihrig:auto-sync

cjihrig commented Oct 2, 2023 •

edited

Loading

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Oct 2, 2023

Uh oh!

nodejs-github-bot commented Oct 3, 2023

Uh oh!

nodejs-github-bot commented Oct 3, 2023 •

edited by cjihrig

Loading

Uh oh!

mcollina left a comment

Uh oh!

github-actions bot commented Oct 4, 2023

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

hhjmmmmmmmm May 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

		@@ -2217,7 +2217,7 @@ function lutimesSync(path, atime, mtime) {
		handleErrorFromBinding(ctx);

Uh oh!

Conversation

cjihrig commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 2, 2023

Uh oh!

nodejs-github-bot commented Oct 3, 2023

Uh oh!

nodejs-github-bot commented Oct 3, 2023 • edited by cjihrig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 4, 2023

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

hhjmmmmmmmm May 2, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cjihrig commented Oct 2, 2023 •

edited

Loading

nodejs-github-bot commented Oct 3, 2023 •

edited by cjihrig

Loading