perf_hooks: reduce overhead of new resource timings#49837
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Sep 30, 2023
Merged
perf_hooks: reduce overhead of new resource timings#49837nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Member
I would use a new symbol for each constructor so that if other parts in the code base need to create something in a way not exposed to userland they need to explicitly import it. We use this pattern in many other places like event_target too. |
benjamingr
reviewed
Sep 25, 2023
42d7511 to
cdcfc29
Compare
Uzlopak
reviewed
Sep 28, 2023
Qard
approved these changes
Sep 28, 2023
anonrig
approved these changes
Sep 28, 2023
Collaborator
Collaborator
Collaborator
|
Landed in e6e320e |
16 tasks
GeoffreyBooth
pushed a commit
to GeoffreyBooth/node
that referenced
this pull request
Oct 1, 2023
PR-URL: nodejs#49837 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Oct 2, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49837 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49837 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49837 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work started on nodejs/performance#109.
This PR should be landed after #49803.
I want to use the symbolkSkipThrowin other classes around the NodeJS codebase, someone had some idea where I should put it? Or create a new symbol and reuse it when possible?Right now, we have this symbol being used onperf_hooksbut there is also an identical symbol onwebstreams, so maybe we can put it in a higher module and import it around the node, I initially thought to put it insideerrors, since we will always use it together withERR_ILLEGAL_CONSTRUCTOR.I will reuse the same symbol only when it inherits some class that exports a symbol, otherwise, I will create a new one.
/cc @nodejs/performance