test: replace forEach with for..of in test-fs-readv.js#49805
Closed
niyashiyas wants to merge 6 commits intonodejs:mainfrom
Closed
test: replace forEach with for..of in test-fs-readv.js#49805niyashiyas wants to merge 6 commits intonodejs:mainfrom
niyashiyas wants to merge 6 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
tniessen
reviewed
Sep 23, 2023
niyashiyas
added a commit
to niyashiyas/node
that referenced
this pull request
Sep 24, 2023
Contributor
Author
|
Made all required changes |
niyashiyas
force-pushed
the
test-fs-readv
branch
from
80ce3aa to
c98662d
Compare
niyashiyas
changed the title
lpinca
approved these changes
Oct 18, 2023
lpinca
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
20 tasks
Collaborator
Collaborator
This was referenced Oct 22, 2023
jasnell
approved these changes
Oct 28, 2023
Collaborator
Collaborator
Collaborator
Contributor
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Contributor
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced forEach with for..of in test-fs-readv.js and test-fs-readv-sync.js