benchmark: add a benchmark for read() of ReadableStreams by debadree25 · Pull Request #49622 · nodejs/node

debadree25 · 2023-09-12T10:42:20Z

While looking at nodejs/performance#82 and trying to find a way to optimise read() realised that there is no specific benchmark for the read() function and the byob variant of read too

Refs: nodejs/performance#82

benchmark/webstreams/readable-read.js

nodejs-github-bot · 2023-09-18T05:19:00Z

Commit Queue failed

- Loading data for nodejs/node/pull/49622
✔  Done loading data for nodejs/node/pull/49622
----------------------------------- PR info ------------------------------------
Title      benchmark: add a benchmark for read() of ReadableStreams (#49622)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/bench-readable-read -> nodejs:main
Labels     benchmark, performance, author ready
Commits    2
 - benchmark: add a benchmark for read() of ReadableStreams
 - fixup! lint
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 12 Sep 2023 10:42:20 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599
   ✘  This PR needs to wait 29 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6218493460

debadree25 · 2023-09-18T07:50:12Z

ah needs another approval

nodejs-github-bot · 2023-09-19T05:45:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/49622
✔  Done loading data for nodejs/node/pull/49622
----------------------------------- PR info ------------------------------------
Title      benchmark: add a benchmark for read() of ReadableStreams (#49622)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/bench-readable-read -> nodejs:main
Labels     benchmark, performance, author ready
Commits    2
 - benchmark: add a benchmark for read() of ReadableStreams
 - fixup! lint
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 12 Sep 2023 10:42:20 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599
   ✘  This PR needs to wait 4 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6231626698

nodejs-github-bot · 2023-09-19T10:46:14Z

Commit Queue failed

- Loading data for nodejs/node/pull/49622 ✔ Done loading data for nodejs/node/pull/49622 ----------------------------------- PR info ------------------------------------ Title benchmark: add a benchmark for read() of ReadableStreams (#49622) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/bench-readable-read -> nodejs:main Labels benchmark, performance, author ready Commits 2 - benchmark: add a benchmark for read() of ReadableStreams - fixup! lint Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49622 Refs: https://github.com/nodejs/performance/issues/82 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 12 Sep 2023 10:42:20 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 49622 From https://github.com/nodejs/node * branch refs/pull/49622/merge -> FETCH_HEAD ✔ Fetched commits as 2ccfb23b7fc8..2f0c075a78da -------------------------------------------------------------------------------- [main de7b9357a5] benchmark: add a benchmark for read() of ReadableStreams Author: Debadree Chatterjee Date: Tue Sep 12 16:09:45 2023 +0530 1 file changed, 49 insertions(+) create mode 100644 benchmark/webstreams/readable-read.js [main b2a9f7b33f] fixup! lint Author: Debadree Chatterjee Date: Tue Sep 12 16:32:19 2023 +0530 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Refs: nodejs/performance#82, skipping..
--------------------------------- New Message ----------------------------------
benchmark: add a benchmark for read() of ReadableStreams

Refs: nodejs/performance#82
PR-URL: #49622
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

[detached HEAD 1a9db4e005] benchmark: add a benchmark for read() of ReadableStreams
Author: Debadree Chatterjee debadree333@gmail.com
Date: Tue Sep 12 16:09:45 2023 +0530
1 file changed, 49 insertions(+)
create mode 100644 benchmark/webstreams/readable-read.js
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! lint

PR-URL: #49622
Refs: nodejs/performance#82
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

[detached HEAD 1a71ac33d2] fixup! lint
Author: Debadree Chatterjee debadree333@gmail.com
Date: Tue Sep 12 16:32:19 2023 +0530
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6234511673

nodejs-github-bot · 2023-09-19T10:54:34Z

Landed in cd97e28

Refs: nodejs/performance#82 PR-URL: #49622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Refs: nodejs/performance#82 PR-URL: nodejs#49622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

benchmark: add a benchmark for read() of ReadableStreams

ace6c05

Refs: nodejs/performance#82

debadree25 requested a review from anonrig September 12, 2023 10:42

nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Sep 12, 2023

fixup! lint

2f0c075

H4ad reviewed Sep 12, 2023

View reviewed changes

benchmark/webstreams/readable-read.js Show resolved Hide resolved

H4ad reviewed Sep 12, 2023

View reviewed changes

benchmark/webstreams/readable-read.js Show resolved Hide resolved

anonrig approved these changes Sep 13, 2023

View reviewed changes

debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 13, 2023

H4ad approved these changes Sep 13, 2023

View reviewed changes

anonrig added the performance Issues and PRs related to the performance of Node.js. label Sep 13, 2023

debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 18, 2023

debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 19, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 19, 2023

debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 19, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2023

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 19, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2023

nodejs-github-bot merged commit cd97e28 into nodejs:main Sep 19, 2023

ruyadorno pushed a commit that referenced this pull request Sep 28, 2023

benchmark: add a benchmark for read() of ReadableStreams

4879e3f

Refs: nodejs/performance#82 PR-URL: #49622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This was referenced Sep 28, 2023

v20.7.1 proposal #49917

Closed

v20.8.0 proposal #49932

Merged

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023

benchmark: add a benchmark for read() of ReadableStreams

11f4cce

Refs: nodejs/performance#82 PR-URL: nodejs#49622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

benchmark: add a benchmark for read() of ReadableStreams#49622

benchmark: add a benchmark for read() of ReadableStreams#49622
nodejs-github-bot merged 2 commits intonodejs:mainfrom
debadree25:ft/bench-readable-read

debadree25 commented Sep 12, 2023

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 18, 2023

Uh oh!

debadree25 commented Sep 18, 2023

Uh oh!

nodejs-github-bot commented Sep 19, 2023

Uh oh!

nodejs-github-bot commented Sep 19, 2023

Refs: nodejs/performance#82
PR-URL: #49622
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #49622
Refs: nodejs/performance#82
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Sep 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

debadree25 commented Sep 12, 2023

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 18, 2023

Uh oh!

debadree25 commented Sep 18, 2023

Uh oh!

nodejs-github-bot commented Sep 19, 2023

Uh oh!

nodejs-github-bot commented Sep 19, 2023

Refs: nodejs/performance#82 PR-URL: #49622 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #49622 Refs: nodejs/performance#82 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Sep 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Refs: nodejs/performance#82
PR-URL: #49622
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

PR-URL: #49622
Refs: nodejs/performance#82
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com