node-api: fix compiler warning in node_api.h by graebm · Pull Request #49103 · nodejs/node

graebm · 2023-08-11T00:37:24Z

Fix -Wstrict-prototypes warning from AppleClang 14.0.3.14030022, compiling C.

My team tests our C addon with -Werror and recent changes to node_api.h broke our build.

/Users/runner/.cmake-js/node-arm64/v18.17.0/include/node/node_api.h:33:65: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)();
                                                                ^
                                                                 void
typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)();
                                                                ^
                                                                 void

The break started when the build machines started using node v18.17.0. Builds from a week ago, using node v18.16.1 were successful.

nodejs-github-bot · 2023-08-11T00:37:28Z

Review requested:

@nodejs/node-api

mhdawson

LGTM

nodejs-github-bot · 2023-08-14T18:04:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53322/

Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022, compiling C, targeting arch arm64 (on x86_64 host). I build my C addon with -Werror and recent changes to node_api.h broke our build.

gabrielschulhof

LGTM

graebm · 2023-08-18T16:16:10Z

Seems like some tests are being flaky. Should I push an empty commit and force tests to re-run? Or wait for someone else to take care of things?

legendecas

Thank you for your contribution!

nodejs-github-bot · 2023-08-20T17:16:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53467/

nodejs-github-bot · 2023-08-22T14:52:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53494/

nodejs-github-bot · 2023-08-23T18:13:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53526/

nodejs-github-bot · 2023-08-29T16:30:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53619/

nodejs-github-bot · 2023-08-29T19:04:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53624/

nodejs-github-bot · 2023-08-30T02:42:32Z

Landed in 9848352

Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022, compiling C, targeting arch arm64 (on x86_64 host). I build my C addon with -Werror and recent changes to node_api.h broke our build. PR-URL: #49103 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022, compiling C, targeting arch arm64 (on x86_64 host). I build my C addon with -Werror and recent changes to node_api.h broke our build. PR-URL: nodejs#49103 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022, compiling C, targeting arch arm64 (on x86_64 host). I build my C addon with -Werror and recent changes to node_api.h broke our build. PR-URL: #49103 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022, compiling C, targeting arch arm64 (on x86_64 host). I build my C addon with -Werror and recent changes to node_api.h broke our build. PR-URL: nodejs/node#49103 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 11, 2023

mhdawson approved these changes Aug 14, 2023

View reviewed changes

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023

node-api: fix compiler warning in node_api.h

9d6783c

Fix "-Wstrict-prototypes" warning from AppleClang 14.0.3.14030022, compiling C, targeting arch arm64 (on x86_64 host). I build my C addon with -Werror and recent changes to node_api.h broke our build.

graebm force-pushed the fix-strict-prototypes branch from e2f7a0e to 9d6783c Compare August 14, 2023 18:10

This was referenced Aug 15, 2023

CI Reliability 2023-08-15 nodejs/reliability#637

Open

CI Reliability 2023-08-16 nodejs/reliability#638

Open

CI Reliability 2023-08-17 nodejs/reliability#639

Open

CI Reliability 2023-08-18 nodejs/reliability#640

Open

gabrielschulhof approved these changes Aug 18, 2023

View reviewed changes

legendecas approved these changes Aug 20, 2023

View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2023

This was referenced Aug 21, 2023

CI Reliability 2023-08-21 nodejs/reliability#641

Open

CI Reliability 2023-08-22 nodejs/reliability#642

Open

github-actions bot mentioned this pull request Aug 23, 2023

CI Reliability 2023-08-23 nodejs/reliability#643

Open

27 tasks

github-actions bot mentioned this pull request Aug 29, 2023

CI Reliability 2023-08-29 nodejs/reliability#649

Open

21 tasks

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2023

nodejs-github-bot merged commit 9848352 into nodejs:main Aug 30, 2023

graebm deleted the fix-strict-prototypes branch August 30, 2023 15:13

UlisesGascon mentioned this pull request Sep 10, 2023

v20.7.0 proposal #49592

Merged

toyobayashi added a commit to toyobayashi/emnapi that referenced this pull request Sep 14, 2023

nodejs/node#49103

d7cc080

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

node-api: fix compiler warning in node_api.h#49103

node-api: fix compiler warning in node_api.h#49103
nodejs-github-bot merged 1 commit intonodejs:mainfrom
graebm:fix-strict-prototypes

graebm commented Aug 11, 2023 •

edited

Loading

Uh oh!

nodejs-github-bot commented Aug 11, 2023

Uh oh!

mhdawson left a comment

Uh oh!

nodejs-github-bot commented Aug 14, 2023

Uh oh!

gabrielschulhof left a comment

Uh oh!

graebm commented Aug 18, 2023

Uh oh!

legendecas left a comment

Uh oh!

nodejs-github-bot commented Aug 20, 2023

Uh oh!

nodejs-github-bot commented Aug 22, 2023

Uh oh!

nodejs-github-bot commented Aug 23, 2023

Uh oh!

nodejs-github-bot commented Aug 29, 2023

Uh oh!

nodejs-github-bot commented Aug 29, 2023

Uh oh!

nodejs-github-bot commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

graebm commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 11, 2023

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 14, 2023

Uh oh!

gabrielschulhof left a comment

Choose a reason for hiding this comment

Uh oh!

graebm commented Aug 18, 2023

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 20, 2023

Uh oh!

nodejs-github-bot commented Aug 22, 2023

Uh oh!

nodejs-github-bot commented Aug 23, 2023

Uh oh!

nodejs-github-bot commented Aug 29, 2023

Uh oh!

nodejs-github-bot commented Aug 29, 2023

Uh oh!

nodejs-github-bot commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

graebm commented Aug 11, 2023 •

edited

Loading