src: add a condition if the argument of `DomainToUnicode` is empty by pluris · Pull Request #49097 · nodejs/node

pluris · 2023-08-10T16:16:56Z

Add an empty check for the input, like DomainToASCII in the line below.

Lines 79 to 82 in f1b3ade

    
           std::string input = Utf8Value(env->isolate(), args[0]).ToString(); 
        
           if (input.empty()) { 
        
             return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), "")); 
        
           }

Refs : #46410

nodejs-github-bot · 2023-08-10T16:17:01Z

Review requested:

@nodejs/url

anonrig

What's the goal of this pull request? Can you provide an example and update your PR with a test?

pluris · 2023-08-11T16:44:01Z

@anonrig Thank you for your comments.
I referred to the IDNA Mapping Table from the WhatWG URL.
I checked the handling of empty strings,
I saw that DomainToASCII and DomainToUnicode should be treated the same.
Therefore, in my opinion, it is in DomainToASCII, but it seems to be missing in DomainToUnicode, so I added it.

IDNA Mapping Table : https://www.unicode.org/reports/tr46/#TableDerivationStep6
DomainToASCII : https://www.unicode.org/reports/tr46/#ToUnicode
DomainToUnicode : https://www.unicode.org/reports/tr46/#ToASCII
WhatWG URL : https://url.spec.whatwg.org/
The same considerations as with domain-to-ASCII apply.

anonrig · 2023-08-11T16:46:06Z

@pluris It already returns an empty string when an empty string is passed. It seems like this is an optimization for performance for the empty input to perform faster.

Welcome to Node.js v20.5.0.
Type ".help" for more information.
> require('url').domainToUnicode('')
''

anonrig · 2023-08-11T16:46:27Z

src/node_url.cc

+    return args.GetReturnValue().Set(
+        String::NewFromUtf8(env->isolate(), "").ToLocalChecked());


Suggested change

return args.GetReturnValue().Set(

String::NewFromUtf8(env->isolate(), "").ToLocalChecked());

return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), ""));

Can you apply the changes?

@anonrig Oh, I'm so sorry. I checked this comment too late. I thought I fixed it, but maybe I didn't add a commit...
It seems that the PR has been merged, but I will fix it.

pluris · 2023-08-11T16:56:50Z

@anonrig
If so, would it be better to do the same by removing the line below?

node/src/node_url.cc

Lines 79 to 82 in f1b3ade

    
           std::string input = Utf8Value(env->isolate(), args[0]).ToString(); 
        
           if (input.empty()) { 
        
             return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), "")); 
        
           }

anonrig · 2023-08-11T16:59:27Z

@pluris I don't think removing it would make a difference since it is a single branch (in c++). So, personally I'm fine with adding it to domainToUnicode as well.

pluris · 2023-08-11T17:07:55Z

@anonrig Thank you for your opinion. It helped me a lot. 😄

nodejs-github-bot · 2023-08-11T17:18:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53205/

anonrig · 2023-08-11T21:52:31Z

@pluris Can you rebase from main and force-push?

pluris · 2023-08-12T00:55:21Z

@anonrig Yes, I did rebase and force-push.

nodejs-github-bot · 2023-08-12T01:02:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53216/

nodejs-github-bot · 2023-08-12T21:13:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53253/

nodejs-github-bot · 2023-08-16T14:08:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53379/

nodejs-github-bot · 2023-08-17T11:51:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53402/

nodejs-github-bot · 2023-08-18T13:39:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53427/

nodejs-github-bot · 2023-08-20T03:14:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53457/

nodejs-github-bot · 2023-08-20T09:55:45Z

Landed in 45e5ec8

PR-URL: #49336 Refs: #49097 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

PR-URL: #49097 Refs: #46410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

PR-URL: #49336 Refs: #49097 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

PR-URL: nodejs#49336 Refs: nodejs#49097 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

PR-URL: #49097 Refs: #46410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

PR-URL: nodejs/node#49097 Refs: nodejs/node#46410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Aug 10, 2023

anonrig reviewed Aug 10, 2023

View reviewed changes

anonrig reviewed Aug 11, 2023

View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023

anonrig approved these changes Aug 11, 2023

View reviewed changes

pluris closed this Aug 11, 2023

pluris reopened this Aug 11, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2023

pluris force-pushed the fix/check_empty_input branch from e2fd13c to 4e380fd Compare August 12, 2023 00:53

anonrig approved these changes Aug 12, 2023

View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2023

This was referenced Aug 13, 2023

CI Reliability 2023-08-13 nodejs/reliability#635

Open

CI Reliability 2023-08-14 nodejs/reliability#636

Open

CI Reliability 2023-08-15 nodejs/reliability#637

Open

github-actions bot mentioned this pull request Aug 17, 2023

CI Reliability 2023-08-17 nodejs/reliability#639

Open

26 tasks

github-actions bot mentioned this pull request Aug 18, 2023

CI Reliability 2023-08-18 nodejs/reliability#640

Open

32 tasks

src: add a condition if the argument of DomainToUnicode is empty

adf338b

pluris force-pushed the fix/check_empty_input branch from 4e380fd to adf338b Compare August 18, 2023 04:18

deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023

deokjinkim approved these changes Aug 20, 2023

View reviewed changes

deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 20, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2023

nodejs-github-bot merged commit 45e5ec8 into nodejs:main Aug 20, 2023

This was referenced Aug 21, 2023

CI Reliability 2023-08-21 nodejs/reliability#641

Open

CI Reliability 2023-08-22 nodejs/reliability#642

Open

CI Reliability 2023-08-23 nodejs/reliability#643

Open

pluris mentioned this pull request Aug 26, 2023

src: modify code for empty string #49336

Closed

pluris deleted the fix/check_empty_input branch August 30, 2023 16:12

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023

src: add a condition if the argument of DomainToUnicode is empty

4a9ae31

PR-URL: #49097 Refs: #46410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

UlisesGascon mentioned this pull request Sep 10, 2023

v20.7.0 proposal #49592

Merged

targos pushed a commit that referenced this pull request Nov 27, 2023

src: add a condition if the argument of DomainToUnicode is empty

8c33731

PR-URL: #49097 Refs: #46410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

	std::string input = Utf8Value(env->isolate(), args[0]).ToString();
	if (input.empty()) {
	return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), ""));
	}

		return args.GetReturnValue().Set(
		String::NewFromUtf8(env->isolate(), "").ToLocalChecked());

Uh oh!

Conversation

pluris commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 10, 2023

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

pluris commented Aug 11, 2023

Uh oh!

anonrig commented Aug 11, 2023

Uh oh!

anonrig Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

anonrig Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

pluris Aug 26, 2023

Choose a reason for hiding this comment

Uh oh!

pluris commented Aug 11, 2023

Uh oh!

anonrig commented Aug 11, 2023

Uh oh!

pluris commented Aug 11, 2023

Uh oh!

nodejs-github-bot commented Aug 11, 2023

Uh oh!

anonrig commented Aug 11, 2023

Uh oh!

pluris commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 16, 2023

Uh oh!

nodejs-github-bot commented Aug 17, 2023

Uh oh!

nodejs-github-bot commented Aug 18, 2023

Uh oh!

nodejs-github-bot commented Aug 20, 2023

Uh oh!

nodejs-github-bot commented Aug 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pluris commented Aug 10, 2023 •

edited

Loading