[v18.x backport] build, deps, test, tools: avoid excessive LTO, debug information#49065
Closed
rockdrilla wants to merge 3 commits intonodejs:v18.xfrom
Closed
[v18.x backport] build, deps, test, tools: avoid excessive LTO, debug information#49065rockdrilla wants to merge 3 commits intonodejs:v18.xfrom
rockdrilla wants to merge 3 commits intonodejs:v18.xfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
rockdrilla
force-pushed
the
build-flags-v18.x
branch
3 times, most recently
from
b8c1210 to
6c1f5e8
Compare
rockdrilla
force-pushed
the
build-flags-v18.x
branch
from
6c1f5e8 to
fff2cb9
Compare
rockdrilla
changed the title
rockdrilla
changed the title
Merged
rockdrilla
force-pushed
the
build-flags-v18.x
branch
from
fff2cb9 to
5c206ed
Compare
Don't link intermediate executables with LTO in order to speed up overall build time. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
condition doesn't apply to this target type (introduced in db910dd) Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
Don't build intermediate executables with debug information in order to save some disk space during build. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla
force-pushed
the
build-flags-v18.x
branch
from
5c206ed to
a4e7542
Compare
Member
|
@mhdawson can you review these changes? (or cc someone that is able to) |
aduh95
changed the title
Contributor
|
v18.x has reached EOL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is backport of #49063 for "v18.x" branch.
Signed-off-by: Konstantin Demin rockdrilla@gmail.com